dev into main#29
Merged
Merged
Conversation
Merge enforce-session-permissions into dev
Merge cache-keybinds into dev
_list_all: materialise DataEquipmentVariant into a dict before the loop — was calling variants.filter().first() per slot per alt. _list_single: batch-fetch DataEquipment and DataEquipmentVariant in two queries before the loop — was hitting the DB twice per slot (36 queries per request for 18 slots). Add REST_FRAMEWORK pagination (PageNumberPagination, page_size=100) to settings for the raw ModelViewSet data endpoints.
Fix dev→main PR workflow head filter and null body guard
Fix N+1 queries in equipment views, add DRF pagination
- 47 pytest tests across LuaParser, IsSessionUser, keybind helpers, and key view behaviours (all passing, 52% coverage) - pytest-cov wired with term-missing + XML output; CI uploads to Codecov - Extract keybind logic from views.py into libs/keybind_builder.py - Add backend/test_settings.py (SQLite in-memory) and conftest.py - Expand lint.yml with test job (Python 3.12, no DB services needed) - Add Lint/Test, Codecov, and Ruff badges to readme.md - Remove dump.txt (personal data), gitignore it - Remove redundant apicore/tests.py
Add test suite, coverage, keybind refactor, and repo cleanup
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 34103880 | Triggered | Generic Password | b9c9fdb | .github/workflows/lint.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.