Skip to content

Use type-safe queryset methods instead of custom ORM queries - #674

Merged
jodal merged 11 commits into
mainfrom
querysets
Jul 19, 2026
Merged

Use type-safe queryset methods instead of custom ORM queries#674
jodal merged 11 commits into
mainfrom
querysets

Conversation

@jodal

@jodal jodal commented Jul 19, 2026

Copy link
Copy Markdown
Owner

This improves code readability and makes the code more type-safe at the same time.

@jodal
jodal merged commit 0b030e6 into main Jul 19, 2026
8 checks passed
@jodal
jodal deleted the querysets branch July 19, 2026 16:32
@codecov

codecov Bot commented Jul 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 56.80000% with 54 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.85%. Comparing base (def70ce) to head (bd109c9).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
src/comics/browser/views.py 9.09% 30 Missing ⚠️
src/comics/core/querysets.py 76.47% 12 Missing ⚠️
src/comics/accounts/views.py 16.66% 5 Missing ⚠️
src/comics/aggregator/downloader.py 0.00% 4 Missing ⚠️
src/comics/accounts/querysets.py 80.00% 1 Missing ⚠️
src/comics/api/views.py 94.73% 1 Missing ⚠️
src/comics/status/views.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #674      +/-   ##
==========================================
+ Coverage   58.91%   59.85%   +0.93%     
==========================================
  Files          41       41              
  Lines        2013     2035      +22     
==========================================
+ Hits         1186     1218      +32     
+ Misses        827      817      -10     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant