Preserve FIFO order through the PriceLevelData round-trip (#131) - #133
Merged
Merged
Conversation
The plain serde path built PriceLevelData::orders from iter_orders() -- the unordered DashMap iterator -- so serde_json round-trips through the public PriceLevelData scrambled price-time priority, the exact property the checksum-protected snapshot package has preserved since #109. The vector is now materialized in queue-consumption order (ascending insertion sequence) and TryFrom<PriceLevelData> re-admits in vector order, so the round-trip preserves FIFO including demotions. Docs state the contract and point persistence at the snapshot package (checksummed, carries statistics). Closes #131
joaquinbejar
added
bug
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PriceLevelData::orderswas built from the unordered DashMap iterator, so around-trip through the plain serde path scrambled price-time priority — the
property the snapshot package has preserved since #109. It now materializes
in queue-consumption order;
TryFromre-admits in vector order, so FIFO(including demotions) survives. Docs point persistence at the snapshot
package.
Testing
Closes #131