Skip to content

updated to work with the latest version of Klipper and some fixes#24

Open
yayuuu wants to merge 11 commits intojoakimtoe:mainfrom
yayuuu:main
Open

updated to work with the latest version of Klipper and some fixes#24
yayuuu wants to merge 11 commits intojoakimtoe:mainfrom
yayuuu:main

Conversation

@yayuuu
Copy link
Copy Markdown

@yayuuu yayuuu commented Feb 9, 2025

  • changed accel_to_decel to minimum_cruise_ratio
  • reworked settings update to more closely reflect printer's state
  • fixed thumbnail source file path when using relative path in the virtual sd card settings

- changed accel_to_decel to minimum_cruise_ratio
- reworked settings update to more closely reflect printer's state
- fixed thumbnail source file path when using relative path in the virtual sd card settings
- simplified configuration (modifying main.py to change klippy.sock is no longer required, it will automatically read the value from Moonraker)
- better remaining time estimate based on print percent, elapsed time and time since last percent update
@tov-marshal
Copy link
Copy Markdown

Yo man, thanks for your amazing job! I think author abandoned this project. So please can you add the LED pull-request so i can just clone your rep if there more updates?

@yayuuu
Copy link
Copy Markdown
Author

yayuuu commented Feb 16, 2025

@tov-marshal Hey, are you talking about this request? #17

It's not as straight forward, as it depends on how the LEDs are defined in the printer.cfg file. In my case (and my file is based on the klipper's own config for the Neptune 3 Pro) it's defined as top_LEDs, so the current hardcoded value in the KlipperLCD works.

Maybe I can read the definition from the config file itself, so it will be independent of what you have in the printer.cfg and then it would work with every printer (just as I did with the klippy.sock location, so it's no longer neccessary to specify correct value).

… how it is declared in the printer.cfg, it will now turn on/off all available LEDs at once

- added support for turning on/off part cooling fans from the settings menu
@tov-marshal
Copy link
Copy Markdown

@tov-marshal Hey, are you talking about this request? #17

Yes, there it is!
LED_Light from TheFeralEngineer config
top_LEDs from klipper3d config

If you can
cat printer.cfg | grep -i 'led'
then you can get all lines of led blocks...

@yayuuu
Copy link
Copy Markdown
Author

yayuuu commented Feb 17, 2025

@tov-marshal You can test my latest commit, it should read the LED name directly from the Moonraker's API (https://moonraker.readthedocs.io/en/latest/external_api/printer/#printer-status-requests) and it should be able to turn all available LEDs at once. I've also added support for turning the fan on/off from the settings menu.

Copy link
Copy Markdown

@SpudBoxTeam SpudBoxTeam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not work please go back to working code this error

Connection.

Web site exists
Traceback (most recent call last):
File "/home/pi/KlipperLCD/main.py", line 224, in
x = KlipperLCD()
File "/home/pi/KlipperLCD/main.py", line 26, in init
self.printer.init_Webservices()
File "/home/pi/KlipperLCD/printer.py", line 439, in init_Webservices
self.max_accel_to_decel = toolhead['max_accel_to_decel']
KeyError: 'max_accel_to_decel'

@yayuuu
Copy link
Copy Markdown
Author

yayuuu commented Mar 9, 2025

@SpudBoxTeam looks like you have an older version of Klipper. These changes are meant to update it to work with the new version.

@SpudBoxTeam
Copy link
Copy Markdown

@SpudBoxTeam looks like you have an older version of Klipper. These changes are meant to update it to work with the new version.

no I have the newest clipper thank you for the response

judokan9 and others added 2 commits June 2, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants