fix(cask): drop the deprecated verified: from the url stanza - #77
Merged
Merged
Conversation
Homebrew deprecated the `verified:` parameter, so every `brew` command touching the tap printed a warning pointing at Casks/reader-md.rb:5. The parameter exists to vouch for a download host unrelated to `homepage`. Ours is github.com/jnahian/reader.md — exactly the homepage — so default URL verification already covers it and the argument was never doing work. release.sh only rewrites the version and sha256 lines, so this stays gone across releases. Closes #76 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015FzPq6pEHPreGzSDystgdL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #76
Homebrew deprecated the
verified:parameter tourl, so everybrewcommand that touched the tap printed:verified:exists to vouch for a download host unrelated tohomepage. Ours isgithub.com/jnahian/reader.md, which is the homepage, so Homebrew's default verification already accepts it — the argument was inert. Removing it is the whole change.release.shonly rewrites theversionandsha256lines (release.sh:93-97), so the deletion survives future releases.Verification
Copied the edited cask into the tap checkout and loaded it:
brew info --cask jnahian/reader.md/reader-md— no warning, cask resolves with the same version, requirements, and artifacts as before. (Tap restored afterwards.)brew audit --caskcould not run on this machine: Homebrew's developer commands refuse withYour Xcode (26.6) at /Applications/Xcode.app is too outdated. Please update to Xcode 27.0. Worth a run wherever Xcode is current.🤖 Generated with Claude Code
https://claude.ai/code/session_015FzPq6pEHPreGzSDystgdL