Skip to content

Scratch: the identifier spelling step fails on a British choice value - #985

Closed
jmrplens wants to merge 1 commit into
fix/choices-units-and-records-by-namefrom
scratch/prove-spelling-step
Closed

jmrplens wants to merge 1 commit into
fix/choices-units-and-records-by-namefrom
scratch/prove-spelling-step

Conversation

@jmrplens

Copy link
Copy Markdown
Owner

Draft to see the new CI step fail on a real defect: verify_amplifier_overload offers "programme" as a choice. The step "Check that every public identifier is spelled in American English" of the parameter-units job should fail; this is closed once it does.

@coderabbitai

coderabbitai Bot commented Oct 17, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the area: electroacoustics Transducers, arrays and electroacoustic devices label Oct 17, 2026
@jmrplens

Copy link
Copy Markdown
Owner Author

Seen red where it should be: in the job "Every public quantity names its unit", the units step passed, "Check that every public identifier is spelled in American English" failed on the "programme" choice, and the Literal step after it was skipped (run 39053135461). Closing; the defect was only here to prove the step.

@jmrplens jmrplens closed this Oct 17, 2026
@jmrplens
jmrplens deleted the scratch/prove-spelling-step branch October 17, 2026 21:28
@github-actions

Copy link
Copy Markdown
Contributor

Numerical conformance

All 1893 conformance checks pass, across 111 domains and 523 standards

1893/1893 checks pass across 111 domains and 523 standards (227 normative designations, 125 further published sources).

Used in the tables below is how much of that clause's published tolerance the deviation consumes: 100 % sits exactly on the limit, 5 % uses a twentieth of the allowance, and a dash means the clause states no two-sided tolerance for the quantity, so there is no budget to spend. It is reported and never used to decide a verdict, which is settled at full precision before any rounding.

Nothing moved: same 1893 checks, same verdicts, same numbers.

Closest to their published limit (top 5)

The rows with the least room left, so the ones a change is most likely to push over.

Standard Quantity Deviation Used
ISO/TR 17534-3:2015 Table 3 Ground-projected path length dp, m 0.005 m 100 %
DIN 4150-2:1999-06 Annex C, Example 5 KB_FTr with hammer b) in the rest hours, Formula (5) -0.005 100 %
DIN 4150-2:1999-06 Annex C, Example 8 KB_FTm over the record with the passage maxima alone -0.0005 100 %
E DIN 4150-2:2023-08 Annex B, Table B.1 KB_FTm,Zug of the metro north by Formula (5) -0.0005 100 %
Jarvis (1996) NPL CIRA(EXT) 010 Appendix B, folio 26 Volume of the coupler of the example, v = pi r^2 L -0.00000000005 m³ 100 %

Fail Tests & coverage: 263844 tests, 57 failures (57 failing)
Python Version Tests Failures Coverage Status
macos-latest-3.12 29316 6 92.0% Fail Failed
macos-latest-3.13 29316 6 92.0% Fail Failed
macos-latest-3.14 29316 6 92.0% Fail Failed
ubuntu-latest-3.12 29316 6 92.0% Fail Failed
ubuntu-latest-3.13 29316 6 92.0% Fail Failed
ubuntu-latest-3.14 29316 6 92.0% Fail Failed
windows-latest-3.12 29316 7 92.0% Fail Failed
windows-latest-3.13 29316 7 92.0% Fail Failed
windows-latest-3.14 29316 7 92.0% Fail Failed

Full report at this commit: docs/CONFORMANCE.md · docs/conformance.json · full CI artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: electroacoustics Transducers, arrays and electroacoustic devices

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant