Conversation
Merge feature/switch2kit-desktop-platforms at 4924dd5, resolving the workflow and build-helper conflicts in favor of Visual Studio 2026 with Swift 6.3.3. The attempted VS 2022 downgrade fails Dolphin's existing _MSC_FULL_VER guard. Preserve the base branch's SDK capacity fix, native SDK preflight, documentation and full application relocation/launch checks. Replace the obsolete regression expectations with checks for the supported runner, matching released Swift inputs >= 6.3, explicit VS 2026 and Swift selection, and failure-propagating SDK/application builds before relocated launch. Do not weaken compiler/STL guards. Validation: 11 integration tests and 4 autoconnect tests pass. Production host and mapping suites pass with Clang and GCC under ASan/UBSan; exact-width SDL adapter checks pass with both compilers. Four negative controls reject the old PR configuration, Swift 6.2.1 on VS 2026, and an ignored SDK build failure. Base Windows application run 35398281931 passed build and relocated launch/quit/relaunch; this new commit still requires its own CI run.
jmonster
merged commit Sep 19, 2026
4ca2766
into
feature/switch2kit-desktop-platforms
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolve the Windows toolchain failure and the conflict with
feature/switch2kit-desktop-platformswithout downgrading Dolphin's required compiler.The original Swift 6.2.1 / VS 2026 run failed because Swift's bundled Clang 19 was rejected by the VS 2026 STL. This PR's attempted VS 2022 downgrade then failed in run 35396313972: Dolphin's
Source/PCH/pch.hrequires_MSC_FULL_VER >= 195136252and rejects that older compiler.Commit
5436ba89286c45b48efbdf7bf3a1e85e092ae6ffmerges base commit4924dd5c6d0904784c6afecd55f2b92fab1418dainto this PR branch, resolving the workflow/helper conflicts in favor of the corrected base implementation:windows-2025-vs2026, Swift 6.3.3, explicit VS 2026 discovery, and one explicitly selected Swift installation.No compiler or STL compatibility guard is suppressed. No release is published, and the PR remains open and unmerged; only its head branch was updated, without force-pushing.
Validation
Local tests used the source artifact for merge commit
9715451caebbb7e9852eef95a71e40d67058a649, whose tree matches base4924dd5, plus the corrected tests. The published test blobb0a913498dc11f400e292564d55b633750b51b14matches the locally tested file.python Tools/test_switch2kit.py: 11 tests passed, including actual CMake platform/backend admission checks.python Tools/test_switch2kit_autoconnect.py: 4 tests passed.CXX=clang++andCXX=g++, each runningTools/test_switch2kit_capacity.py: passed against the production SDL adapter.Tools/test_switch2kit_host.py --sanitizeandTools/test_switch2kit_mapping.py --sanitize: passed with AddressSanitizer and UndefinedBehaviorSanitizer.The unchanged application/toolchain implementation on base
4924dd5passed the full Windows build and relocated launch/quit/relaunch run. This PR head has fresh CI runs; the base result is not a claim that all checks on the new head have completed. Native Windows/macOS application execution was not performed in the local Linux environment. No physical Bluetooth/controller qualification is claimed.