test: remove editorial length, ordering, branding and UI-copy assertions - #73
Merged
Merged
Conversation
This was referenced Sep 18, 2026
Remove the line-count replacement that enforced links before code, along with exact license-index wording checks. Retain actual broken-link, public protocol value, binary exclusion, and distribution-notice integrity checks.
jmonster
changed the title
jmonster
changed the title
Keep package verification of CREDITS.md and both required upstream license texts, upstream application identity/copyright, missing or altered notices, and signing order. LICENSES/README.md is navigation prose, not a required license text; it is still copied with the directory but is no longer an integrity assertion. Retained repository (4), distribution-notices (5), and application identity/signing checks pass.
jmonster
added a commit
that referenced
this pull request
Sep 18, 2026
…cations Bundle the actual Swift runtime dependency closure alongside the facade, with complete verified Swift/ICU licenses; retain OS graphics, Bluetooth and C++ runtime prerequisites. Remove compiler RPATHs from Linux package copies only. Exercise relocated C/SDL consumers on both maintained Windows toolchains and strengthen Linux loader tests with extraction and missing-runtime negative controls. Add shared Linux/X11 and Windows GUI archive qualification: isolated owned profiles, no developer PATH/library overrides, loaded-module location checks, stable application window, ordinary shutdown and relaunch. These do not claim hardware or pristine first-use acceptance. Fix Dolphin's MSVC /WX size conversion using the actual bounded event-capacity constant, without suppressing warnings or weakening motion tests. Include #73's documentation-index cleanup while retaining all license texts and attribution. Local reviewed tree matches 4f2876d. Linux deployment/loader inspection, all 3 real SDL consumers, 19 launch-supervisor regressions, 4 repository checks, 5 distribution-notice checks and application identity/signing checks pass. New native CI must qualify final packages.
jmonster
added a commit
that referenced
this pull request
Sep 19, 2026
…cations Bundle the actual Swift runtime dependency closure alongside the facade, with complete verified Swift/ICU licenses; retain OS graphics, Bluetooth and C++ runtime prerequisites. Remove compiler RPATHs from Linux package copies only. Exercise relocated C/SDL consumers on both maintained Windows toolchains and strengthen Linux loader tests with extraction and missing-runtime negative controls. Add shared Linux/X11 and Windows GUI archive qualification: isolated owned profiles, no developer PATH/library overrides, loaded-module location checks, stable application window, ordinary shutdown and relaunch. These do not claim hardware or pristine first-use acceptance. Fix Dolphin's MSVC /WX size conversion using the actual bounded event-capacity constant, without suppressing warnings or weakening motion tests. Include #73's documentation-index cleanup while retaining all license texts and attribution. Local reviewed tree matches 4f2876d. Linux deployment/loader inspection, all 3 real SDL consumers, 19 launch-supervisor regressions, 4 repository checks, 5 distribution-notice checks and application identity/signing checks pass. New native CI must qualify final packages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
GitHub reports this cleanup was merged on September 19, 2026 at 01:51:44 UTC, with resulting main commit
bdabcceec65d34027461400bb66542d9942fc1ba. The reviewed PR head wasaaa3747cced550a2bd1b558dbcad7d24de1f60ae. This session updated the audit/validation record; it did not perform that merge or publish a release.Removed editorial assertions
The cleanup removes the README line-count restriction and its links-before-code/handwritten-heading-layout replacement, license-index prose requirements, display-name/browser-description assertions, exact English UI-copy assertions and the redundant distributed hash of
LICENSES/README.md.The five affected files are
tests/repository/test_layout.py,tests/app-identity/check.py,tests/distribution-notices/test_notices.py,tests/output-health/run.shandscripts/verify-distribution-notices.py.The two failures exposed by README PR #72 were the same
138 not less than 100documentation-policy assertion, not Bluetooth test failures.LICENSES/README.mdremains distributed as navigation material; it is not itself a required license text.Preserved material coverage
Broken local-link/license-target checks, documented protocol bit values, executable/bundle identity, source-only distribution, required complete licenses and attribution, missing/altered-notice failures, signing/order checks, output-capability guards, serial-addressed rumble and compiled production-sink coverage remain. No controller, Bluetooth, concurrency, native-build or packaging suite is disabled.
The fork audit retains real ABI, lifecycle, mapping/rollback, permissions, signing and compiler-compatibility checks. Dolphin's format-only UI gate is removed separately in jmonster/dolphin#5; its executable regressions are retained and a real feature-disabled application build without Swift is added. Cemu's existing wiring checks no longer prescribe the option-description wording.
Reviewed-head validation
All eight workflows completed successfully for
aaa3747, not merely the older handoff revision:The same cleanup is present in PR #75's reviewed SDK source and passed its independently rerun retained portable, Swift, native C/SDL and distribution tests. Its presence in a controller branch does not turn editorial restrictions into hardware tests.
Remaining dependency order
The cleanup prerequisite is now complete. Review #75 next, preserving its reviewed SDK commit in reachable history, then the maintained fork PRs after their final pinned native/application validation. A squash/rebase of #75 requires deliberately repinning and revalidating both forks. No further merge or production release is authorized by this audit update.