Repository navigation
ci: pin docs-engine to v0.4.2 (search Tab-out, untitled pages) - #10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves this project's site build from docs-engine v0.4.1 to v0.4.2. The pin
in
.github/workflows/site.ymlis the only change.Why
v0.4.2 fixes two small things in the search that v0.4.1 added:
only Escape or a click elsewhere closed it.
#heading, is titled by itsfile name in the nav, the page
<title>and search results. Before, thenav entry and
<title>came out empty.Verification
Built locally with
jolt run buildagainst docs-engine v0.4.2 on thistree: the build completed and
docs/check-site.shpassed ("index, guide overview, evaluation, conformance and the ADR all present, every URL under /ebb"). CI on this PR is the authoritativecheck.
Prior art