Enable optionally serving applications under subpath/path prefix#42
Open
tgerakitis wants to merge 3 commits intojlesage:masterfrom
tgerakitis:master
Open
Enable optionally serving applications under subpath/path prefix#42tgerakitis wants to merge 3 commits intojlesage:masterfrom tgerakitis:master
tgerakitis wants to merge 3 commits intojlesage:masterfrom
tgerakitis:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By adding an alias to the nginx default site configuration we can define an environment variable
PATH_PREFIXthat enables the application to be accessed by the provided value.The change is very small and simple, I also extended the docs accordingly.
If it is bothersome that the app can be accessed in two paths now when left unconfigured namely by root
example.com:5800/& the default unconfigured pathexample.com:5800/sed_path_prefix/, then I can simply comment out the lines and remove the comments when the ENV is set.This PR consists of three commits I'd like to have squashed into one.
ps: this is my first merge request on github pls tell me if I need to fix anything.