Skip to content

修复未来状态时间掩盖心跳过期 (#87) #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jlcbk merged 1 commit into from
May 31, 2026
Merged

修复未来状态时间掩盖心跳过期 (#87) #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion status_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def is_status_stale(

current_time = now or datetime.now()
age_seconds = (current_time - updated_at).total_seconds()
return age_seconds > stale_after_seconds
return age_seconds < 0 or age_seconds > stale_after_seconds


def default_status() -> Dict[str, Any]:
Expand Down
8 changes: 8 additions & 0 deletions tests/test_status_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,14 @@ def test_is_status_stale_uses_supplied_threshold(self):
self.assertTrue(status_model.is_status_stale(status, 60))
self.assertFalse(status_model.is_status_stale(status, 300))

def test_is_status_stale_treats_future_time_as_untrusted(self):
now = datetime(2026, 5, 29, 10, 0, 0)
future_status = {
"updated_at": (now + timedelta(minutes=5)).strftime("%Y-%m-%d %H:%M:%S")
}

self.assertTrue(status_model.is_status_stale(future_status, 900, now=now))


if __name__ == "__main__":
unittest.main()
Loading