Skip to content
This repository was archived by the owner on Aug 12, 2021. It is now read-only.

Update Sketch View From RN - #27

Closed
gensc004 wants to merge 13 commits into
jgrancher:react-native-0.40from
houserater:update-view-capability
Closed

Update Sketch View From RN#27
gensc004 wants to merge 13 commits into
jgrancher:react-native-0.40from
houserater:update-view-capability

Conversation

@gensc004

@gensc004 gensc004 commented Apr 13, 2017

Copy link
Copy Markdown
  • Added an image property that can be used by React Native to force an update to the native view with the new function setImage(image) where image is a base64 encoded string.
  • Allowed for transparent background, and switched the default background from blackColor to clearColor.

Similar to what @stantoncbradley did in response to #6, I wanted to be able to draw on top of an image, and I also wanted to add the ability to undo lines that were drawn. I am working in RN ~0.40, so I opened this up against the react-native-0.40 branch.
sketch

@dkretsch12

Copy link
Copy Markdown

👍

@jgrancher

jgrancher commented Apr 28, 2017

Copy link
Copy Markdown
Owner

Hey @gensc004,
Thanks for your help! Would you be able to rebase your changes from master please? :)

@gensc004

Copy link
Copy Markdown
Author

Absolutely!

@jgrancher

Copy link
Copy Markdown
Owner

Hey @gensc004! I've finally merged #28, which means the module should now works on RN >= 0.40, directly from master. Would you be able to change your destination branch to be master, and rebase? Thanks! 💃

@bshyong

bshyong commented Sep 1, 2017

Copy link
Copy Markdown

^ looks great! would love to use this once it is merged

@HankieCodes

Copy link
Copy Markdown
Contributor

My coworker @gensc004 and I cleaned up this PR with replacement PR #33, so we can close this one and continue discussing things over there.

@gensc004 gensc004 closed this Dec 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants