AX-2205: Add SH support - #78
Merged
Merged
Conversation
Self-hosted JPDs do not serve /ml/core off the platform root — the same APIs sit behind /bridge-client — so every probe 404s and the caller reports the feature as absent. Each /ml/core call site now retries once behind /bridge-client after a 404, and adopts that result only when it evidences a working endpoint, so no pre-existing failure changes its status, detail or exit code: - modules/core/agent-guard-check.mjs and its jfrog-mcp-management copy: the HTTP call is split into fetchSetting(), giving each attempt its own AbortController so the retry cannot inherit a spent timeout budget. Only an enabled/registry-off answer replaces the root verdict. - jfrog-detect-catalog-runtime.mjs: the fallback runs in both parts. Part A resolves the prefix anonymously; Part B retries independently for a JPD that answers 401 anonymously at the root but 404s the authenticated call. Part A adopts only a code that says the catalog is deployed, Part B only a 2xx of the catalog's shape or a 403 — so a proxy's 400/501 or a WAF's 401 cannot promote a non-blocking exit 1 into a blocking exit 3, or blame credentials that are fine. The marketplace registration script already had this fallback; it is unchanged. Tests: 13 new unit tests drive the injectable module copy through a route-map fetch double (no retry on 200/401/403/5xx/network, retry on 404, both-404 keeps the original reason, a fresh unaborted signal per attempt). A new integration suite spawns both skill scripts against a localhost JPD stub with a fake jf on PATH and HOME redirected, covering SaaS (asserting /bridge-client is never probed), both resolution paths, not_entitled, and every case where the fallback must not win. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
yanivt-jfrog
reviewed
Sep 3, 2026
…ssignment Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
yanivt-jfrog
approved these changes
Sep 3, 2026
davida-jfrog
added a commit
to jfrog/cursor-plugin
that referenced
this pull request
Sep 3, 2026
Self-hosted JFrog Platform instances serve these APIs behind `/bridge-client` rather than off the platform root, so the Agent Guard and AI Catalog checks always 404 and report the feature as unavailable. Both checks now retry once behind `/bridge-client` after a 404, and use that answer only when it comes from a working endpoint — every other outcome keeps its existing behaviour. SaaS is unaffected. Port of jfrog/claude-plugin#78. Tests: `node --test` — 13 unit, 17 integration, plus the two pre-existing suites, all passing and now wired into CI. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self-hosted JFrog Platform instances serve these APIs behind
/bridge-clientrather than off the platform root, so the Agent Guard and AI Catalog checks always 404 and report the feature as unavailable.Both checks now retry once behind
/bridge-clientafter a 404, and use that answer only when it comes from a working endpoint — every other outcome keeps its existing behaviour. SaaS is unaffected.Tests:
node --test— 95 unit, 17 integration, all passing.