Skip to content

Add ability to modify system permissions#1869

Merged
paustint merged 2 commits into
mainfrom
feat/permissions/system-permissions
Jul 22, 2026
Merged

Add ability to modify system permissions#1869
paustint merged 2 commits into
mainfrom
feat/permissions/system-permissions

Conversation

@paustint

Copy link
Copy Markdown
Contributor

Introduce functionality to manage system permissions within the permissions management interface. This includes updates to state management and the addition of a new table component for system permissions.

Copilot AI review requested due to automatic review settings July 19, 2026 20:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for viewing/editing Salesforce System Permissions (the PermissionSet.Permissions* boolean fields) in the Manage Permissions UI, including data loading via describe + dynamic SOQL, dependency cascading behavior to mirror Salesforce’s UI, save plumbing, and export support.

Changes:

  • Extend permission-manager types/state to include a new systemPermission permission type and save payloads.
  • Add system-permission field discovery (from PermissionSet describe), querying, table rows/columns, dependency cascading, and save/update flows.
  • Include system permissions in exports (CSV/XLSX), dirty tracking, reset-on-org-change, and add focused unit tests.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
libs/types/src/lib/ui/permission-manager-types.ts Adds system-permission types, table cell shapes, and save-record contracts.
libs/shared/ui-core/src/state-management/manage-permissions.state.ts Adds atom to store loaded system-permission definitions/results.
libs/features/manage-permissions/src/utils/system-permission-dependencies.ts Introduces curated system-permission dependency graph + tooltip strings and closure computation.
libs/features/manage-permissions/src/utils/permission-manager-utils.ts Adds query construction, save batching, and post-save refresh mapping for system permissions.
libs/features/manage-permissions/src/utils/permission-manager-table-utils.tsx Adds system-permission columns/rows, dependency cascading across rows, dirty extraction, and UI wiring.
libs/features/manage-permissions/src/utils/permission-manager-export-utils.ts Adds “System Permissions” worksheet/CSV generation and wires into export entrypoints.
libs/features/manage-permissions/src/utils/tests/permission-manager-system-permissions.spec.ts Adds unit tests covering field discovery, row building, save grouping, dependency closures, and cascading behavior.
libs/features/manage-permissions/src/usePermissionRecords.tsx Loads settable Permissions* fields from describe, queries values, and builds systemPermissionMap.
libs/features/manage-permissions/src/ManagePermissionsSelection.tsx Resets the new system-permission atom when selections change.
libs/features/manage-permissions/src/ManagePermissionsEditorSystemPermissionTable.tsx New table component for system permissions with bulk actions and dirty tracking.
libs/features/manage-permissions/src/ManagePermissionsEditor.tsx Integrates system permissions into tabs, dirty/error tracking, save/reset/export flows.
libs/features/manage-permissions/src/ManagePermissions.tsx Ensures system-permission state resets appropriately when org state changes.
apps/jetstream/src/app/components/core/AppStateResetOnOrgChange.tsx Resets system-permission state on org change in web app.
apps/jetstream-desktop-client/src/app/components/core/AppStateResetOnOrgChange.tsx Resets system-permission state on org change in desktop client.

@paustint
paustint force-pushed the feat/permissions/system-permissions branch from 696daa5 to 76f0170 Compare July 19, 2026 22:53
@paustint
paustint requested review from Copilot July 19, 2026 23:00
@paustint
paustint force-pushed the feat/permissions/system-permissions branch from 76f0170 to 25cab1c Compare July 19, 2026 23:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated no new comments.

@paustint
paustint merged commit 3190e1c into main Jul 22, 2026
8 checks passed
@paustint
paustint deleted the feat/permissions/system-permissions branch July 22, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants