Add ConfigMaps discovery and reporting support #754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add ConfigMaps field to Snapshot struct for data upload - Register ConfigMaps informer in kubernetesNativeResources - Add ark/configmaps extractor function for data processing - Update test coverage to include ConfigMaps - Add ConfigMaps configuration to disco-agent templates - Update example configurations and test snapshots This enhancement allows the agent to discover and report ConfigMap resources alongside existing resources like Pods and Daemonsets.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds support for discovering and reporting Kubernetes ConfigMap resources to the CyberArk Discovery and Context API. The changes follow the existing pattern used for other Kubernetes resources like Pods and DaemonSets.
Changes:
- Added ConfigMaps field to the Snapshot data structure for data upload
- Registered ConfigMaps informer in the Kubernetes native resources map
- Added ark/configmaps extractor function for processing ConfigMap data
- Updated test coverage, example configurations, and chart templates
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
internal/cyberark/dataupload/dataupload.go |
Added ConfigMaps field to Snapshot struct |
pkg/datagatherer/k8s/dynamic.go |
Registered ConfigMaps informer in kubernetesNativeResources map |
pkg/client/client_cyberark.go |
Added ark/configmaps extractor function to defaultExtractorFunctions map |
pkg/client/client_cyberark_test.go |
Added ark/configmaps to defaultDynamicDatagathererNames test list |
examples/machinehub.yaml |
Added ConfigMaps data gatherer configuration example |
examples/machinehub/input.json |
Added ConfigMaps entry to example input data |
deploy/charts/disco-agent/templates/configmap.yaml |
Added ConfigMaps configuration to helm chart template |
deploy/charts/disco-agent/tests/__snapshot__/configmap_test.yaml.snap |
Updated test snapshots to include ConfigMaps configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enhancement allows the agent to discover and report ConfigMap resources alongside existing resources like Pods and Daemonsets.