Open
Conversation
birkskyum
force-pushed
the
Fix-JSX-and-TSX
branch
from
38eb904 to
82b4ac1
Compare
Author
|
@orta , what are your thoughts on this? |
Collaborator
|
I'm not wild on the change personally, unless the vscode team have opinions, it's probably not something I'd merge I think your reasoning is pretty solid, but I don't think it's worth changing everyones defaults for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While React did popularize the JSX/TSX syntax, there is an increasing number of libraries other than react that rely on JSX/TSX. Notable examples are SolidJS, Vue and Preact which can use the .tsx/.jsx extensions, or in the case of vue have a .vue allowing it to have a dedicated icon.
To account for this diverse ecosystem, this PR therefore remove an obsolete assumption that "jsx = react" and changes the jsx/tsx to a jsx/tsx icons accordingly. This also making jsx<->tsx migration a bit easier, while keeping the spec / test colors as they are, in accordance with #611.
Before
After
