Mobile UI: tighten spacing, panel styling, and resume audio on visibility#14
Open
jeromepotter wants to merge 2 commits intomainfrom
Open
Mobile UI: tighten spacing, panel styling, and resume audio on visibility#14jeromepotter wants to merge 2 commits intomainfrom
jeromepotter wants to merge 2 commits intomainfrom
Conversation
✅ Deploy Preview for les-cercles ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
--panel-surface,--panel-surface-strong,--panel-border-soft) so panels render appropriately in light and dark modes..panel-titleto left alignment and adding wrapping rules forsummary.panel-header-rowon mobile.window.innerHeight * 0.8towindow.innerHeight * 0.68and reducing gaps/padding for#controls-footer,#side-controls, and#planet-list-wrapso the planet chips and submenus sit closer under the sequencer.AudioEngine.resumehelper and aresumeAudioEngineIfNeededcaller wired tovisibilitychange,pageshow,focus,touchstart, andpointerdownevents so the audio context is reinitialized or resumed when the app regains focus.Testing
python -m http.server 8000) and ran a Playwright script to load the page at a mobile viewport (390x844) and capture a screenshot (artifacts/mobile-layout.png), and the page loaded successfully and produced the screenshot.Codex Task