Skip to content

Add support for custom credential store when syncing from a secret#139

Open
jespernylendklp wants to merge 1 commit intojenkinsci:masterfrom
jespernylendklp:feature/JENKINS-75962-custom-credential-store
Open

Add support for custom credential store when syncing from a secret#139
jespernylendklp wants to merge 1 commit intojenkinsci:masterfrom
jespernylendklp:feature/JENKINS-75962-custom-credential-store

Conversation

@jespernylendklp
Copy link

Feature merge request to implment https://issues.jenkins.io/browse/JENKINS-75962 . We now provide the user with the option to define the credentialStore (Folder) in which the credential should be stored. This can be utilized to improve security, as Folders can be limited via other security configurations.

Testing done

  1. Built the code with mvn clean install.
  2. Created a Folder in Jenkins "myfolder"
  3. Created a secret
kind: Secret
apiVersion: v1
metadata:
  name: test-plugin-secret
  namespace: kalypso-builder-kalypso
  labels:
    credential.sync.jenkins.openshift.io: 'true'
  annotations:
    jenkins.openshift.io/credential.store: myfolder
    jenkins.openshift.io/secret.name: test-plugin-secret-name
data:
  filename: ZmFuY3ktcGFudHN5
type: Opaque
  1. Uploaded the plugin file (.hpi) to our running Jenkins instance in production
  2. Restarted Jenkins
  3. Verified that the new credential is created in the store of the myfolder Folder.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@jespernylendklp
Copy link
Author

@prdhamdh - I see you have a lot of commits lately. Any chance you could take a look at this feature request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant