Fix 404s on form validation#93
Merged
mjeanson merged 2 commits intoMar 26, 2026
Merged
Conversation
Signed-off-by: Kienan Stewart <kstewart@efficios.com>
This avoids 404 errors when attempting to validate the startupTimesToRetryOnFailure and startupWaitingPeriodSeconds fields when adding or editing a computer with Jenkins 2.541. This form is available since Jenkins 2.360. @see https://www.jenkins.io/doc/developer/security/csp/#legacy-javascript-checkurl-validation Signed-off-by: Kienan Stewart <kstewart@efficios.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the checkUrl format used in
configure-entries.jellyto themodernformat.With jenkins 2.541.3, the old format seems to havestopped working. When loading the form to add or edit a computer, the fields would show a jenkins 404 page after each attempt to validate the field values.
Testing done
With both jenkins 2.478 and 2.541:
mvn hpi:runstartupTimesToRetryOnFailureandstartupWaitingPeriodSecondsin the computer form to ensure that the values are validatedSubmitter checklist