[JENKINS-24076] Add a configuration option for stable build comparison #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cppcheck to compare results against a stable build rather than the last build.
Member
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
Contributor
|
I will merge it a release new version on Sunday (hopefully), thanks. |
| * | ||
| * @since 1.20 | ||
| */ | ||
| private boolean stableBuild; |
Contributor
There was a problem hiding this comment.
stableBuild would be stored to build.xml together with all non-transient fields now. This data file should contain only data from the particular build, stableBuild is global configuration flag.
<org.jenkinsci.plugins.cppcheck.CppcheckBuildAction>
<owner class="build" reference="../../.."/>
<result>
<owner class="build" reference="../../../.."/>
<statistics>
<errorCount>0</errorCount>
<warningCount>1</warningCount>
<styleCount>22</styleCount>
<performanceCount>2</performanceCount>
<informationCount>1</informationCount>
<noCategoryCount>0</noCategoryCount>
<portabilityCount>0</portabilityCount>
<versions>
<string>1.61</string>
</versions>
</statistics>
<stableBuild>false</stableBuild> <!-- *** HERE *** -->
</result>
<healthReportPercentage>-1</healthReportPercentage>
</org.jenkinsci.plugins.cppcheck.CppcheckBuildAction>
Author
|
I might be able to get these changes in this weekend. If I have time, I'll also look into the delta issue too. What is the mail group I need to email to get added as a maintainer? Thanks |
Contributor
|
👍 |
|
Any update on merging this? This is much needed behaviour, and should probably even be the default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a configuration option for Cppcheck to compare results against a stable build rather than the last
build.