Draft
Fix duplicate page tokens when navigating jelly-pagination window#2
Conversation
Copilot
AI
changed the title
[WIP] Fix duplicated page 5 in jelly pagination
Fix duplicate page tokens when navigating jelly-pagination window
Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pagination intermittently rendered duplicate numeric buttons when crossing window boundaries (e.g., moving from page 1 to 6 could show
5twice). This change makes page-window construction uniqueness-safe and adds a focused regression covering the reported path.Pagination window generation
pagesToShow()to build candidate pages via aSet(1,total,current ± 1) and then render sorted pages.Regression coverage
page === 6)5appears exactly once