fix(release): gate winget-submit-render on the package actually existing - #82
Merged
Conversation
WINGET_TOKEN has been configured since 2026-08-20, so the token check alone no longer makes this job inert -- on the next tag it would run winget-releaser against Coderise.OKF4net.Render, which is not published to winget-pkgs yet. winget-releaser UPDATES an existing package; it cannot create one, so the job would fail and take the release run red with it. The bind is circular: the artifacts the first manual submission needs are produced by the very release that would run this job. So the job now also requires the repository variable WINGET_RENDER_PUBLISHED=true, flipped once after that first PR is merged, and skips with an actionable notice until then. Coderise.OKF4net needs no equivalent gate -- it is already published. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
The workflow change correctly preserves existing behavior for Coderise.OKF4net while preventing a predictable failure mode for Coderise.OKF4net.Render and the documentation matches the new gate.
Pull request overview
This PR prevents winget-submit-render from failing release runs by adding an explicit gate that ensures Coderise.OKF4net.Render is only submitted after it actually exists in microsoft/winget-pkgs. This aligns the workflow behavior with the “first submission must be manual” constraint of winget-releaser.
Changes:
- Gate
winget-submit-renderon bothWINGET_TOKENandWINGET_RENDER_PUBLISHED=true, skipping with an actionable notice otherwise. - Update the winget packaging README to document the intended three-step sequence (release → manual submit → flip variable).
File summaries
| File | Description |
|---|---|
| packaging/winget/README.md | Documents the new gating variable and the recommended first-submission workflow for the render package. |
| .github/workflows/release.yml | Adds WINGET_RENDER_PUBLISHED gate to keep releases green until the render package exists in winget-pkgs. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WINGET_TOKENhas been configured on this repo since 2026-08-20, so the token check alone no longer makeswinget-submit-renderinert — which is what #80 assumed.On the next tag it would run
winget-releaseragainstCoderise.OKF4net.Render, a package that is not published to winget-pkgs yet.winget-releaserupdates an existing package; it cannot create one. The job would fail and take the release run red with it.The bind is circular: the artifacts the first manual submission needs are produced by the very release that would run this job.
So the job now requires a second condition — the repository variable
WINGET_RENDER_PUBLISHED=true— and skips with an actionable notice until then:Coderise.OKF4netneeds no equivalent gate — it is already published, so its job is correct as it stands.packaging/winget/README.mdnow spells out the three-step sequence (release → manual submit → flip the variable) instead of saying the job "will keep failing", which is no longer what happens.Verified: workflow YAML parses, no tabs, 1272 tests green.
🤖 Generated with Claude Code