Skip to content

fix(release): gate winget-submit-render on the package actually existing - #82

Merged
jchable merged 1 commit into
devfrom
winget-render-gate
Sep 6, 2026
Merged

fix(release): gate winget-submit-render on the package actually existing#82
jchable merged 1 commit into
devfrom
winget-render-gate

Conversation

@jchable

@jchable jchable commented Sep 6, 2026

Copy link
Copy Markdown
Owner

WINGET_TOKEN has been configured on this repo since 2026-08-20, so the token check alone no longer makes winget-submit-render inert — which is what #80 assumed.

On the next tag it would run winget-releaser against Coderise.OKF4net.Render, a package that is not published to winget-pkgs yet. winget-releaser updates an existing package; it cannot create one. The job would fail and take the release run red with it.

The bind is circular: the artifacts the first manual submission needs are produced by the very release that would run this job.

So the job now requires a second condition — the repository variable WINGET_RENDER_PUBLISHED=true — and skips with an actionable notice until then:

Coderise.OKF4net.Render is not published to winget-pkgs yet, so there is nothing to update. Submit this release's manifests manually (they are attached to the Release), then set the repository variable WINGET_RENDER_PUBLISHED=true so future releases submit automatically.

Coderise.OKF4net needs no equivalent gate — it is already published, so its job is correct as it stands.

packaging/winget/README.md now spells out the three-step sequence (release → manual submit → flip the variable) instead of saying the job "will keep failing", which is no longer what happens.

Verified: workflow YAML parses, no tabs, 1272 tests green.

🤖 Generated with Claude Code

WINGET_TOKEN has been configured since 2026-08-20, so the token check alone
no longer makes this job inert -- on the next tag it would run
winget-releaser against Coderise.OKF4net.Render, which is not published to
winget-pkgs yet. winget-releaser UPDATES an existing package; it cannot
create one, so the job would fail and take the release run red with it.

The bind is circular: the artifacts the first manual submission needs are
produced by the very release that would run this job. So the job now also
requires the repository variable WINGET_RENDER_PUBLISHED=true, flipped once
after that first PR is merged, and skips with an actionable notice until
then. Coderise.OKF4net needs no equivalent gate -- it is already published.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings September 6, 2026 18:28

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The workflow change correctly preserves existing behavior for Coderise.OKF4net while preventing a predictable failure mode for Coderise.OKF4net.Render and the documentation matches the new gate.

Pull request overview

This PR prevents winget-submit-render from failing release runs by adding an explicit gate that ensures Coderise.OKF4net.Render is only submitted after it actually exists in microsoft/winget-pkgs. This aligns the workflow behavior with the “first submission must be manual” constraint of winget-releaser.

Changes:

  • Gate winget-submit-render on both WINGET_TOKEN and WINGET_RENDER_PUBLISHED=true, skipping with an actionable notice otherwise.
  • Update the winget packaging README to document the intended three-step sequence (release → manual submit → flip variable).
File summaries
File Description
packaging/winget/README.md Documents the new gating variable and the recommended first-submission workflow for the render package.
.github/workflows/release.yml Adds WINGET_RENDER_PUBLISHED gate to keep releases green until the render package exists in winget-pkgs.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@jchable
jchable merged commit d983085 into dev Sep 6, 2026
9 checks passed
@jchable
jchable deleted the winget-render-gate branch September 6, 2026 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants