fix(example-app): drop vestigial tutorial-forge-cli dep (clean fresh install)#70
Merged
Merged
Conversation
…install) example-app declared `tutorial-forge-cli` but never imports it — `pnpm forge` runs the CLI via `tsx ../cli/src/main.ts` (source). The dep made pnpm try to link the CLI's bin into example-app on install, which fails with a scary `[WARN] Failed to create bin … ENOENT` on a fresh clone because the CLI's dist/ isn't built yet. Harmless (the quick-start uses tsx, and npm consumers never see it), but it's the first line of output a repo cloner sees. Removing the unused dep eliminates it; `pnpm forge` still works (verified via `forge list`). Found via a fresh-clone quick-start smoke test ahead of launch. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-launch polish, found via a fresh-clone smoke test of the README quick-start.
Problem
On a fresh
git clone+pnpm install, the first line of output is:example-appdeclarestutorial-forge-clias a dependency, so pnpm tries to link itstutorial-forge/tforgebins — but the CLI'sdist/isn't built at install time, so it fails. Benign (install completes; the quick-start runs the CLI viatsx ../cli/src/main.ts, not the bin; npm consumers never see it) — but it's a scary-looking warning on the exact path a HN reader takes, on their very first command.Fix
tutorial-forge-cliis not imported anywhere in example-app —pnpm forgeusestsxon the CLI source. Removing the unused workspace dep stops pnpm from attempting the bin link.Verified
Reproduced the fresh condition (
rm -rf packages/cli/dist+pnpm install): no moreFailed to create binwarning, andpnpm forge liststill runs fine via tsx. The full quick-start (pnpm forge render) already produces a valid MP4 from a clean clone.No CHANGELOG entry —
example-appisprivate, so this doesn't touch the published packages (no republish).🤖 Generated with Claude Code