fix(core): broaden recap-framing lint to accept accomplishment recaps (#49)#63
Merged
Conversation
…#49) The strict-mode lint that nudges the last step to close with a recap (#36) only matched a fixed cue set ("to recap", "you're ready", …), so a valid past-tense accomplishment recap false-warned. Widen RECAP_CUE_RE to also match "you created/set up/added/…" accomplishment phrasing and the "from here you…" hand-off, bringing it to parity with the much looser INTRO_CUE_RE. All existing cues are kept; advisory-only, never fails a render. Tested with the real umami recap that slipped through. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…lint # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #49.
Problem
The strict-mode framing lint (#36) warns when the last step's narration "doesn't close with a recap", gated on
RECAP_CUE_RE, which only matched a fixed cue set ("to recap", "in summary", "you're ready", "now you can", …). A well-written recap using past-tense accomplishment phrasing matched none of them, so strict mode emitted a false-positive warning. Real example from umami's #133 dogfood that slipped through:The asymmetry:
INTRO_CUE_REis much looser, so the objective side passed easily while the recap side over-nagged.Fix
Widen
RECAP_CUE_REto also accept:created / added / built / set up / configured / enabled / published / …from here you…hand-off connectorAll existing cues are kept (no regression); the lint stays advisory and never fails a render. This is heuristic tuning, not a rendering change — it just makes the lint trustworthy enough to leave on.
Tests
Added a spec test using the real umami recap above, asserting strict mode emits no recap warning for it. Full suite: 170 unit tests pass; build clean.
🤖 Generated with Claude Code