Bump Cargo dependencies declared under an alias - #438
Open
johncarmack1984 wants to merge 1 commit into
Open
johncarmack1984 wants to merge 1 commit into
johncarmack1984 wants to merge 1 commit into
Conversation
A dependency renamed with `package`, e.g. `ffi = { package = "javascriptcore-rs-sys", version = "1.1" }`, keeps its requirement under the alias. Dependencies were matched by their table key only, so the aliased requirement never bumped and the release commit could not resolve.
`resolveDepKey` finds the alias through `package`, and the dependency reads and writes go through it in `[dependencies]`, `[dev-dependencies]`, `[build-dependencies]`, `[target.*.dependencies]` and a root `[workspace.dependencies]` table.
Contributor
Package Changes Through 1885b42There are 2 changes which include @covector/files with patch, @covector/apply with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
This was referenced Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Came out of tauri-apps/javascriptcore-rs#90, where the release PR failed to build. covector bumped
javascriptcore-rs-systo 2.0.0, but the crate depending on it declares it asand the requirement stayed at
1.1.getDepBumpVersionmatched dependencies by their table key only, so an alias never matched and the requirement was never bumped.The alias is now resolved through
package(resolveDepKeyin@covector/files), and the reads and writes ingetPackageFileVersion/setPackageFileVersiongo through it, so[dependencies],[dev-dependencies],[build-dependencies],[target.*.dependencies]and an aliased root[workspace.dependencies]entry all bump under the alias. A dependency declared under its own name resolves to itself, so the existing fixtures are unchanged.Two fixtures: the sub-table form above plus an inline alias in a
[target]table, and an aliased root entry consumed as{ workspace = true }. Four tests, all red before the change. 184 passing, typecheck clean.