Improve ComfyUI workflow integration - #144
Conversation
|
Maintainers/author: thanks for tackling #5 — this is a large, multi-surface PR and there are currently several open ComfyUI PRs (#137/#138/#143/#144). To reduce review+merge risk, it may help to treat one as canonical and ask others to close/supersede. For this PR specifically:
If you want, I can help draft a maintainer-facing checklist that matches a minimal merge plan (and maps cleanly to Boss bounty expectations). |
|
Thanks for the triage notes. I pushed a small follow-up commit here: Current PR/check status from my side:
{"mergeStateStatus":"UNSTABLE","statusCheckRollup":[]}Local validation I ran on this branch:
I also addressed the two concrete doc/test asks:
On scope/splitting: I am happy to split this into smaller PRs if maintainers prefer. Suggested order:
For bounty acceptance, I implemented the broad interpretation of #5: local execution, cloud execution, catalog/import/apply, graph preview, and media categories. If the maintainer/Boss wants a smaller minimum acceptance target first, I can trim this PR to the canonical slice and move the remaining work into follow-ups. |
|
Follow-up review-assist for #5 / PR #144 after the latest author update. Thanks for the concrete validation notes and the follow-up commit. The added details make this PR much easier to evaluate as a possible canonical #5 landing path. What now looks materially stronger:
Remaining merge/bounty-risk items I would keep visible for maintainers:
Suggested next maintainer decision:
This keeps the queue moving without adding another duplicate implementation. |
|
Maintainers: fork CI now passes on the latest PR head commit 1fcf9f8: https://github.com/starsaintf/clapper/actions/runs/26874115687 Upstream PR #144 still reports mergeStateStatus=UNSTABLE because the upstream pull_request workflows are currently �ction_required rather than failed. Could you please approve/run the upstream CI and E2E & Unit Tests workflows for this PR? Thanks. |
|
I re-tested the focused ComfyUI prompt builder coverage while reviewing this PR and found one small blocker on current main: the spec referenced ComfyUIWorkflowApiGraph, the prompt helper functions, and ClapperComfyUiInputIds without importing them, and the app also imports lodash subpaths without declaring lodash as a runtime dependency. I opened a small support PR for that here: Validation on the support PR: Result: 11/11 tests pass. This does not replace #144; it is just a tiny dependency/test hygiene patch that should make the ComfyUI review path easier and remove one unrelated failure while maintainers decide which #5 implementation becomes canonical. |
Summary
Validation
Closes #5