Skip to content

fix(quality): harden local validation - #35

Merged
jbdevprimary merged 4 commits into
mainfrom
chore/docs-security-audit
Aug 24, 2026
Merged

fix(quality): harden local validation#35
jbdevprimary merged 4 commits into
mainfrom
chore/docs-security-audit

Conversation

@jbdevprimary

Copy link
Copy Markdown
Contributor

Fixes local Go package discovery around Sourcey dependencies and resolves repository-wide lint findings.

@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 14 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 9c50ea56-5849-4941-a8ce-2e9b0cfa35a3

📥 Commits

Reviewing files that changed from the base of the PR and between 24b2f21 and 120ea43.

📒 Files selected for processing (7)
  • pkg/context/safe_log_test.go
  • pkg/diff/diff.go
  • pkg/observability/tracing.go
  • pkg/pipeline/aws_context.go
  • pkg/pipeline/graph.go
  • pkg/pipeline/pipeline.go
  • scripts/go-packages.sh

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@amazon-q-developer amazon-q-developer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR successfully addresses repository-wide lint findings and hardens local validation. All changes are code quality improvements that work correctly:

  • Test Fixes: Corrected Unicode escape sequences in test strings to use proper Go escape syntax
  • Code Efficiency: Replaced inefficient sb.WriteString(fmt.Sprintf(...)) patterns with direct fmt.Fprintf(&sb, ...) calls across multiple files
  • Error Handling: Improved error variable naming to avoid shadowing and enhance clarity
  • Build Configuration: Added appropriate path exclusions for node_modules and docs/dist
  • Linting: Added suppression comment for intentional Zipkin exporter usage

No defects found that would block merge. The changes improve code quality, maintainability, and build reliability.


You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

@jbdevprimary
jbdevprimary marked this pull request as ready for review August 24, 2026 17:07
@sonarqubecloud

Copy link
Copy Markdown

@jbdevprimary
jbdevprimary merged commit 044e101 into main Aug 24, 2026
20 checks passed
@jbdevprimary
jbdevprimary deleted the chore/docs-security-audit branch August 24, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant