Skip to content

fix(release): read draft package assets through API - #398

Merged
jbdevprimary merged 2 commits into
mainfrom
fix/draft-package-publisher
Aug 24, 2026
Merged

fix(release): read draft package assets through API#398
jbdevprimary merged 2 commits into
mainfrom
fix/draft-package-publisher

Conversation

@jbdevprimary

Copy link
Copy Markdown
Contributor

Fixes the v0.35.5 package-manifest publication failure. The publisher now resolves signed manifest assets through the draft-aware release view and authenticated asset APIs; gh release download cannot retrieve a draft. The job uses only its short-lived repo token for draft visibility, while PKGS_GITHUB_TOKEN remains the sole package-repo writer.\n\nValidation: bash scripts/ci/test_publish_cli_manifests.sh; go test ./tests/releasecontrol -count=1; actionlint .github/workflows/release.yml.

@jbdevprimary
jbdevprimary enabled auto-merge August 24, 2026 21:19
@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 14 seconds.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 6a1fc6a8-6797-4371-8248-4c1add47c820

📥 Commits

Reviewing files that changed from the base of the PR and between 3932873 and f3e84d3.

📒 Files selected for processing (4)
  • .github/workflows/release.yml
  • packaging/publish-cli-manifests.sh
  • scripts/ci/test_publish_cli_manifests.sh
  • tests/releasecontrol/release_control_test.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@amazon-q-developer amazon-q-developer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes correctly fix the draft package asset access issue by switching from gh release download to the GitHub API with Accept: application/octet-stream. The implementation properly uses the short-lived repository token with contents: write permission (limited to the release job), while PKGS_GITHUB_TOKEN remains the package-repo writer. The test updates and contract validations ensure the new asset retrieval pattern is enforced.


You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

@jbdevprimary

Copy link
Copy Markdown
Contributor Author

Follow-up hardening added in the latest commit: the package-head verifier and premerge smoke use only their short-lived repository token with contents: write to read draft assets. The organization credential is not exposed; package writes stay isolated to PKGS_GITHUB_TOKEN, and Homebrew/Scoop runs after credentials are removed.\n\nValidation: go test ./tests/releasecontrol -count=1; actionlint .github/workflows/release.yml.

@sonarqubecloud

Copy link
Copy Markdown

@jbdevprimary
jbdevprimary merged commit 9f48893 into main Aug 24, 2026
41 checks passed
@jbdevprimary
jbdevprimary deleted the fix/draft-package-publisher branch August 24, 2026 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant