fix(release): read draft package assets through API - #398
Conversation
|
Warning Review limit reachedNext included review available in 14 seconds. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
The changes correctly fix the draft package asset access issue by switching from gh release download to the GitHub API with Accept: application/octet-stream. The implementation properly uses the short-lived repository token with contents: write permission (limited to the release job), while PKGS_GITHUB_TOKEN remains the package-repo writer. The test updates and contract validations ensure the new asset retrieval pattern is enforced.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
|
Follow-up hardening added in the latest commit: the package-head verifier and premerge smoke use only their short-lived repository token with |
|



Fixes the v0.35.5 package-manifest publication failure. The publisher now resolves signed manifest assets through the draft-aware release view and authenticated asset APIs;
gh release downloadcannot retrieve a draft. The job uses only its short-lived repo token for draft visibility, while PKGS_GITHUB_TOKEN remains the sole package-repo writer.\n\nValidation:bash scripts/ci/test_publish_cli_manifests.sh;go test ./tests/releasecontrol -count=1;actionlint .github/workflows/release.yml.