refactor: extract Meshy generator to standalone package - #132
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Important Review skippedToo many files! This PR contains 109 files, which is 9 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (109)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
The refactoring to extract the Meshy generator into a standalone package is well-structured. The new declarative pipeline approach using the standalone CLI is cleaner than maintaining an in-monorepo client.
Critical Issue Found:
- The shell script has a crash risk due to unbound variable expansion when no .env file exists
Once the shell script issue is resolved, this extraction should be safe to merge. The configuration files are properly structured, and the approach of using uvx with version pinning provides good reproducibility.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
|
|
||
| echo "=== All brand assets generated ===" | ||
| echo "Check scripts/brand-assets/*/concept-*.png for results" | ||
| uvx "${ENV_ARGS[@]}" \ |
There was a problem hiding this comment.
🛑 Crash Risk: The array expansion "${ENV_ARGS[@]}" will cause the script to crash with "unbound variable" error when ENV_ARGS is empty due to set -u on line 2. When no .env file exists, ENV_ARGS remains uninitialized and bash's unbound variable protection triggers a fatal error.
| uvx "${ENV_ARGS[@]}" \ | |
| uvx ${ENV_ARGS[@]+"${ENV_ARGS[@]}"} \ |
|
|
|
1 participant
Outcome
Removes the duplicated in-monorepo Meshy client/package now that
jbcom/meshy-content-generatoris the standalone OSS owner andvendor-fabricowns provider transport. The retained brand pipeline is declarative and consumes the standalone CLI instead of carrying another client.Evidence
meshy-content-generator==0.2.0pinRelease order
vendor-fabric2.2.0 is published. The standalone GitHub 0.2.0 release exists; its PyPI trusted publisher is the sole remaining publication step before consumer release closeout.