Skip to content

Conversation

@jbcoe
Copy link
Owner

@jbcoe jbcoe commented Jan 31, 2026

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request migrates the codebase from a simple package named py-cppmodel to a namespace package xyz-cppmodel that provides the xyz.cppmodel module. The migration includes updating imports, test assertions, and internal string representations to reflect the new namespace structure. Additionally, the dependency lock file has been updated with a newer version of the clang package and consolidated Python version resolution markers.

Changes:

  • Renamed package from py-cppmodel to xyz-cppmodel and restructured as a namespace package under xyz.cppmodel
  • Updated all imports and references from py_cppmodel to xyz.cppmodel in tests and notebooks
  • Updated internal __repr__ methods to use the new namespace in their string representations
  • Upgraded clang dependency from version 14.0 to 21.1.7 in the lock file

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
uv.lock Updated package name from py-cppmodel to xyz-cppmodel, upgraded clang from 14.0 to 21.1.7, and consolidated Python version resolution markers
tests/test_parse_standard_library_includes.py Updated imports from py_cppmodel to xyz.cppmodel
tests/test_cppmodel.py Updated imports and test assertions to reference xyz.cppmodel instead of py_cppmodel
src/xyz/cppmodel.py Updated all __repr__ methods to use xyz.cppmodel namespace instead of py_cppmodel
pyproject.toml Changed package name to xyz-cppmodel, removed sdist configuration, and updated wheel build to specify namespace package structure
Sandbox.ipynb Updated imports to use xyz.cppmodel and changed kernel display name
Comments suppressed due to low confidence (1)

src/xyz/cppmodel.py:66

  • The string literal "self.type.name" should be formatted to display the actual value. This line should use string formatting similar to line 67, such as: return "<xyz.cppmodel.FunctionArgument {}>".format(self.type.name) or use an f-string.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"metadata": {
"kernelspec": {
"display_name": "Python 3 (ipykernel)",
"display_name": "py-cppmodel",
Copy link

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The kernel display name is set to "py-cppmodel" which references the old package name. For consistency with the namespace migration, consider updating this to "xyz-cppmodel" or a more generic name like "Python 3".

Suggested change
"display_name": "py-cppmodel",
"display_name": "xyz-cppmodel",

Copilot uses AI. Check for mistakes.
@jbcoe jbcoe merged commit edc4435 into main Jan 31, 2026
11 checks passed
@jbcoe jbcoe deleted the jbcoe/xyz-cppmodel branch January 31, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants