Simplify tests by including C++ source inline #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR refactors the test suite by embedding the C++ test source code directly within the Python test file instead of maintaining it as a separate external file. The change improves test maintainability by keeping test data alongside test code.
Changes:
- Moved C++ source code from external file
sample.ccinto an inlineSOURCEconstant in the test file - Updated test setup to use the
unsaved_filesparameter to provide the inline source to the clang parser - Deleted the now-unnecessary
sample.ccfile
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test_py_cppmodel.py | Added inline SOURCE constant containing C++ code and configured TranslationUnit to use it via unsaved_files parameter |
| sample.cc | Removed external C++ source file as it's now defined inline in the test |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.