fix: wallet error classification, auto-retry dropped requests, actionable feedback - #19
Merged
Merged
Conversation
…ctionable toasts 'Couldn't reach the wallet' was a dead-end catch-all that collapsed three distinct failures into one useless message: - code -31000 'Provider did not return a response': the extension's background worker was suspended by the browser and dropped the request while waking. Now retried automatically once — succeeds in practice, user never sees an error. - 'No installed Stacks wallet found': the page can't see an injected provider (e.g. per-site extension access). Now explains exactly what to do: click the extension icon once to grant site access. - User cancels arriving in foreign shapes: instanceof JsonRpcError is unreliable across module copies and wallet-thrown plain objects. New wallet-errors module classifies by numeric code and message shape. Unknown failures now surface the actual error detail in the toast, so field reports are debuggable instead of generic. Same hardening applied to the transaction signing path (stx_callContract), which shares the sleeping-worker failure mode.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Third and final hardening pass on the wallet flow. The "Couldn't reach the wallet" toast was a catch-all hiding three distinct failure modes — reading the @stacks/connect v8 source, its throw paths are now each handled properly:
-31000Provider did not return a responseinstanceof JsonRpcErrorfails across module copies / wallet-thrown objectswallet-errorsmodule classifies by code (−31001/−32000) + message shapeSame hardening applied to transaction signing (
stx_callContract), which shares the sleeping-worker failure mode.Verify
tsc --noEmit+npm run buildclean