docs(skill): PR lifecycle discipline - fold-first, rebase cadence, closure conventions

[jaylfc]

Adds a PR lifecycle section to the taOS development skill so builder agents using it inherit the working agreements the review gate already enforces:

1. Fold-first: open findings on existing PRs outrank starting new slices; priority is fold, then rebase CONFLICTING PRs, then new work.
2. Rebase cadence + the stale-base rule: a green run computed before the base moved is stale (the fix(security): move GitHub App RSA key from plaintext config to SecretsStore #2009/feat(github): add GitHub App installation flow (C1) #1932 incident); keep the open-PR set under ~10.
3. Closures always link a successor: Superseded by / Landed via / Abandoned because - no silent closes (feat(update): add GPG signature verification for auto-update #1927/feat(store): add Ed25519 manifest signing and verification for install-v2 #1924 were correct closes that cost hours of forensics for lack of a link).
4. One PR per slice, fix+test together (contributor-pitfalls Dynamic NPU core allocation #13).

Docs-only. Once merged, agents pull latest dev to pick up the updated skill.

Summary by CodeRabbit

• Documentation
  • Added contributor guidance for managing pull request lifecycles.
  • Clarified expectations for resolving existing feedback, rebasing conflicting changes, rerunning checks, linking successor work, and avoiding duplicate pull requests.

[qodo-code-review]

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: b2bd1834-726e-4de3-8056-6572ba946fbd

📥 Commits

Reviewing files that changed from the base of the PR and between 57630db and a47fb4c.

📒 Files selected for processing (1)

• .claude/skills/taos-development-skill/SKILL.md

---

📝 Walkthrough

Walkthrough

The contributor skill documentation adds PR lifecycle rules covering existing findings, rebasing and CI reruns, successor-linked closures, and one-PR-per-slice organization.

Changes

PR lifecycle guidance

Layer / File(s)	Summary
Document PR lifecycle rules .claude/skills/taos-development-skill/SKILL.md	Adds guidance to resolve existing folds first, rebase and rerun CI after base-branch changes, link successor PRs or state abandonment reasons when closing, and keep fixes with proving tests in one PR.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

• jaylfc/taOS#1871: Updates the same contributor documentation file with related Git and PR workflow rules.
• jaylfc/taOS#1948: Adds overlapping rebasing, CI, and PR lifecycle guidance in the same contributor documentation.
• jaylfc/taOS#2000: Updates the same workflow documentation with related bot-review and CI procedures.

Suggested reviewers: hognek

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the documentation change and highlights the main workflow rules added.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch docs/dev-skill-pr-lifecycle

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[gitar-bot]

Important

You are using the Gitar free plan. Upgrade to unlock code review, CI analysis, auto-apply, custom automations, and more.

_Gitar

[kilo-code-bot]

WARNING: Reference to docs/contributor-pitfalls.md (and "pitfall 13") may be an unreachable path/number.

This section instructs agents to read docs/contributor-pitfalls.md and cites "pitfall 13". I was unable to verify the file exists at that exact path or that the pitfall numbering matches (the sandbox blocked the verification API calls). If the path is wrong (e.g. it lives under a different directory) or the numbering has drifted, the instruction silently breaks and agents won't find the referenced items. Please confirm the path resolves from repo root and that pitfall #13 is in fact the fix-and-test-in-one-PR item; consider linking the absolute repo path or a heading anchor instead of a bare relative path.

---

Reply with @kilocode-bot fix it to have Kilo Code address this issue.

[kilo-code-bot]

Code Review Summary

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity	Count
CRITICAL	0
WARNING	1
SUGGESTION	0

Issue Details (click to expand)

WARNING

File	Line	Issue
.claude/skills/taos-development-skill/SKILL.md	270	Reference to docs/contributor-pitfalls.md / "pitfall 13" may be an unreachable path or stale number (could not verify due to sandbox API restrictions)

Files Reviewed (1 file)

• .claude/skills/taos-development-skill/SKILL.md - 1 issue

Fix these issues in Kilo Cloud

---

_{Reviewed by hy3:free · Input: 36.7K · Output: 2.2K · Cached: 125.8K}

[jaylfc]

Verified against origin/dev: docs/contributor-pitfalls.md exists (merged today via #2040) and item 13 is exactly the cited rule ("A fix and its test belong in one PR"). The bot could not reach the file from its sandbox; the reference is correct as written. Merging.