Skip to content

test: replace always-true assert with issubclass check in test_installer_class_available #1979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hognek wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

test: replace always-true assert with issubclass check in test_installer_class_available #1979

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
12548bc
fix(install): route LXC port allocation through centralized allocator
hognek Jul 17, 2026
4607350
test: strengthen allocator import assertion per Kilo suggestion
hognek Jul 17, 2026
dc1c8ae
test: replace always-true assert with issubclass check in test_instal…
hognek Jul 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tests/installers/test_port_allocator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
"""Tests for host-port allocation: every handed-out port is probed free."""
import socket

from tinyagentos.installers.base import AppInstaller
from tinyagentos.installers.docker_installer import DockerInstaller
from tinyagentos.installers.lxc_installer import LXCInstaller
from tinyagentos.installers.port_allocator import (
Expand Down Expand Up @@ -129,5 +130,5 @@ def test_allocate_host_port_imported(self):
)

def test_installer_class_available(self):
"""LXCInstaller is importable (sanity check — no import errors from the refactor)."""
assert LXCInstaller is not None
"""LXCInstaller is a proper AppInstaller subclass (class hierarchy regression check)."""
assert issubclass(LXCInstaller, AppInstaller)
Loading