Shrink RepoKeel to retrieval, conditional learning and exceptional recovery - #29
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
INDEPENDENT_REVIEW=PASS Counting unit: mandatory RepoKeel action in one ordinary uninterrupted real task using RepoKeel's generated project rules; excludes product work, project-owned verification, optional helpers, conditional knowledge writes, and advisory hook messages.
Reviewed full candidate diff against supplied requirements and current Issue #28. No new schema/store/agent/router/governance capability. External task/code/delivery/verification authority is explicit. Normal lifecycle hook returns before binding reads; unbound exceptional recovery does not request initialization. Retained hooks are resume/clear/compact and PreCompact. Old state readers and CLI implementation are unchanged; knowledge assets are not migrated or deleted. Promotion requires actual later task reuse. Compatibility delivery/bootstrap instructions are explicitly subordinate, not a new normal-task chain. Evidence inspected: targeted-tests.log reports 46 tests passed; package-validation.json valid=true and two hook commands checked. The extracted-package representative flow covers silent normal startup/stop with no runtime directory, then explicit actual handoff, bound recovery, strict resume, and unchanged state bytes. Retrieval/no-write and conditional-learning instruction contracts are covered by focused static tests; this is prompt behavior evidence, not a claim of a new executable knowledge engine. No full suite rerun and no product files changed by reviewer. |
Closes #28.
Normal tasks previously received work-unit lifecycle instructions from bootstrap assets and startup/stop hooks even without interruption. RepoKeel now requires only purposeful retrieval at task start and conditional learning after acceptance; ordinary tasks create no recovery state. Recovery hooks are limited to actual resume/context loss or compaction of already-bound work.
The core contract, agent entry prompts, bootstrap/handoff templates and necessary public descriptions now share this boundary. Existing CLI/state schemas and historical readers remain intact for explicit recovery. No host installation, release, Vault migration, EA change or new governance capability is included.
Validation
python3 scripts/validate_package.pyandgit diff --checkpassed.Removed obligations
Conservative normal-task mandatory count: 3 -> 2. Before: retrieval; provide the main actor an actor-owned work unit (bootstrap template); learning. After: retrieval; conditional learning. Removed startup resume/bind advice, stop checkpoint/close advice and subagent isolation prompts are additional reductions, not counted as hard gates. Project-owned development/CI/review safety steps are excluded from this RepoKeel-only count.
One independent review passed against
7a7fb7609bd29267318bcb15452a051fb3fa3eab, with zero blocking findings and an independently confirmed 3 -> 2 mandatory-step count. Review record is in the PR comments. Merge waits for current repository CI. No repair or second review layer was needed.