Created an API to easily define django model connections#28
Open
shreyas44 wants to merge 4 commits intojaydenwindle:masterfrom
Open
Created an API to easily define django model connections#28shreyas44 wants to merge 4 commits intojaydenwindle:masterfrom
shreyas44 wants to merge 4 commits intojaydenwindle:masterfrom
Conversation
…go model subscriptions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created a simple API to easily define subscriptions related to django models.
Using the
DjangoObjectSubscription, you can define the subscribtion like below:Why use this?
DjangoObjectSubscription, the structure of it is very similar to defining mutations usinggraphene.Mutation.Some things that could be added:
DjangoObjectTypein theMetasubclass instead of the model and output type. (Adding this as optional would probably be better)on_save,on_update,on_delete, functions separately which are run when a record from the model is created, updated and deleted respectively. (Again optional)Let me know if it would be beneficial to add either of the features.
Also, would it be better to pass the operation and instance under a single argument
eventwhich can then be accessed fromevent.operationandevent.instance?I guess this would resolve #11