Fix LloRegionBuilder::VcvtNarrowFloatToF32 NaN sign handling for F8E4M3B11FNUZ#347
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
Fix LloRegionBuilder::VcvtNarrowFloatToF32 NaN sign handling for F8E4M3B11FNUZ#347copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
test_841869919
branch
from
e7d0600 to
e324613
Compare
…M3B11FNUZ F8E4M3B11FNUZ only has one NaN value that is encoded with sign bit set to `1`. This updates type conversions to ignore the sign bit for NaN for the type. PiperOrigin-RevId: 841869919
copybara-service
bot
force-pushed
the
test_841869919
branch
from
e324613 to
2d12d2c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix LloRegionBuilder::VcvtNarrowFloatToF32 NaN sign handling for F8E4M3B11FNUZ
F8E4M3B11FNUZ only has one NaN value that is encoded with sign bit set to
1. This updates type conversions to ignore the sign bit for NaN for the type.