test: add plugin routing tests for bundled upx plugin#347
Conversation
Covers namespace passthrough routing and the plugins doctor binary health check for the recently bundled upx plugin, which shipped without test coverage.
Covers namespace passthrough routing and the plugins doctor binary health check for the recently bundled komiser plugin, which shipped without test coverage.
Covers namespace passthrough routing and the plugins doctor binary health check for the recently bundled wtfutil plugin, which shipped without test coverage.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
FAIL — the diff adds new plugin routing test files (komiser, upx, wtfutil) rather than doing the objective, which here is not a coding task but an instruction to avoid overlapping in-flight PRs; the The verification gate passed, but this change may not address the stated objective. Review before merging. |
|
Warning Review limit reached
Next review available in: 10 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🏛️ Automaintainer architecture review: VIOLATION The diff adds new test files under The change passed verification, but it violates this repo's architecture rules. The PR was set to draft and auto-merge is held — review before marking it ready. |
|
Automaintainer Review Verdict: APPROVED — Changes add Jest routing tests for three untested bundled plugins (upx, komiser, wtfutil) following the established eza-plugin test pattern. No production code changes; proper temp dir cleanup in afterAll; no overlap with open PRs #343–346. External review comments flagging 'OFF-OBJECTIVE' and 'architecture violation' are not technically valid — placing tests in |
|
Approved by automaintainer review team — ready for human merge |
Automated maintenance run by automaintainer.
Focus:
WORK ALREADY IN FLIGHT — do not overlap:
These automaintainer pull requests are already open and awaiting review. Do NOT re-implement, refactor, or restructure the files they touch — pick non-overlapping work, and never recreate a change an open PR already makes. If your objective unavoidably overlaps one of these, choose a different, complementary improvement instead.
touches: tests/coder-plugin.test.js, tests/pkl-plugin.test.js, tests/rbspy-plugin.test.js
touches: tests/diun-plugin.test.js, tests/notion-cli-plugin.test.js, tests/slim-plugin.test.js
touches: tests/help.test.js, tests/mcp-diagnostics.test.js, package.json
touches: plugins/atac/install-guidance.json, plugins/atac/meta.json, plugins/atac/plugin.json, plugins/dolt/install-guidance.json, plugins/dolt/meta.json, plugins/dolt/plugin.json, plugins/otree/install-guidance.json, plugins/otree/meta.json, plugins/otree/plugin.json, plugins/ov/install-guidance.json, plugins/ov/meta.json, plugins/ov/plugin.json (+3 more)
Branch:
am/am-f17c27-ti3vy5Summary
Add jest routing tests for three recently-bundled but untested plugins: upx, komiser, and wtfutil. Each test installs the plugin against a fake binary on PATH, asserts the CLI routes 'namespace passthrough' commands correctly (command name + forwarded args), and verifies 'plugins doctor' reports the binary dependency as healthy. Mirrors the existing eza-plugin test pattern; no production code changes.
Diff: