The modern mode, "use strict"#83
Open
DKumar2169 wants to merge 5 commits intojavascript-tutorial:masterfrom
Open
The modern mode, "use strict"#83DKumar2169 wants to merge 5 commits intojavascript-tutorial:masterfrom
DKumar2169 wants to merge 5 commits intojavascript-tutorial:masterfrom
Conversation
|
|
rskhan167
requested changes
Oct 16, 2021
Contributor
rskhan167
left a comment
rskhan167
left a comment
There was a problem hiding this comment.
Thanks for submitting the PR. Good work, there's a few changes then we are good to go.
Also, please don't add or remove any line, a couple of places I have added a remark to remove extra line please compare with original file and check in other places too. Thanks.
|
Please make the requested changes. After it, add a comment "/done". |
Contributor
|
Hi @DKumar2169, I have reviewed your PR. Great work, it looks good. There were few changes needed like removal of extra space and line. I have committed those changes. Please have a look at it and let me know if anything needs to be changed. Then, we can merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made some changes Please review if I did this correct so I can work on it more