Java 01. ДЗ 05. Малютина Катя, подгруппа 2 by ekaterinaMaljutina · Pull Request #58 · java-course-au/assignments-2017-1

ekaterinaMaljutina · 2017-04-01T21:20:45Z

sproshev · 2017-04-10T20:07:32Z

+public final class Collections {
+
+    public static <T, R>
+    Iterable<R> map(Function1<? super T, R> f, Iterable<T> a) {


см что написано про возвращаемые типы в задании

sproshev · 2017-04-10T20:08:25Z

+
+    public abstract Boolean apply(T t);
+
+    static final Predicate ALWAYS_TRUE = new Predicate() {


generic параметры?

sproshev · 2017-04-10T20:08:31Z

+        }
+    };
+
+    static final Predicate ALWAYS_FALSE = new Predicate() {


и здесь

sproshev · 2017-04-10T20:09:48Z

@@ -0,0 +1,272 @@
+package ru.spbau.mit;


wildcard'ы не проверяются

ленивость предикатов не проверяется

тесты конечно желательно по соответствующим классам разносить

ekaterinaMaljutina · 2017-05-06T15:19:27Z

@sproshev тут, я наверно забыла написать, что поправила замечания)

sproshev · 2017-05-06T22:04:23Z

+        public Boolean apply(Object o) {
+            return false;
+        }
+    };


надо заиспользовать ALWAYS_T и F в тестах, тогда станет понятно, есть ли какие-то проблемы в них)

sproshev · 2017-05-06T22:05:05Z

+        ArrayList<String> str = new ArrayList<>();
+        str.add("bbbb");
+        str.add("aaa");
+        str.add("ccc");


List<String> str = Arrays.asList("bbbb", "aaa", "ccc");

sproshev · 2017-05-06T22:06:10Z

+            public Boolean apply(Object object) {
+                return null;
+            }
+        }, new ArrayList<Integer>());


Collections.emptyList()

sproshev · 2017-05-06T22:06:32Z

+        for (int i = value, n = 0; n < 20; i++, n++) {
+            Assert.assertTrue(i + 1 == f.apply(i));
+            Assert.assertTrue(i - 1 == g.apply(i));
+            Assert.assertTrue(i == f.compose(g).apply(i));


assertEquals

ekaterinaMaljutina · 2017-05-07T09:11:09Z

@sproshev Поправила.

sproshev · 2017-05-12T00:12:01Z

Predicate.ALWAYS_TRUE.apply(new Object()); не компилируется

ekaterinaMaljutina · 2017-05-12T16:50:17Z

@sproshev Поправила.

sproshev · 2017-05-13T10:40:28Z

9

functional java impl

fe95020

sproshev suggested changes Apr 10, 2017

View reviewed changes

ekaterinaMaljutina added 2 commits April 13, 2017 20:07

fix test lazy and, or. add wildcards test

410ebe1

fix style

935bc5a

sproshev suggested changes May 6, 2017

View reviewed changes

fixed

013cfe7

ekaterinaMaljutina added 2 commits May 7, 2017 12:14

fix empty list

464216c

fix style

cdfe511

fix always predicate

d7c8c19


		public abstract Boolean apply(T t);

		static final Predicate ALWAYS_TRUE = new Predicate() {

Conversation

ekaterinaMaljutina commented Apr 1, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ekaterinaMaljutina commented May 6, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ekaterinaMaljutina commented May 7, 2017

Uh oh!

sproshev commented May 12, 2017

Uh oh!

ekaterinaMaljutina commented May 12, 2017

Uh oh!

sproshev commented May 13, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants