Repository navigation
ci: update checkout and setup-python to current majors - #740
Conversation
|
Note: the workflow runs on this PR show action_required because it is the first PR from my fork. They need a maintainer approval click to start; nothing is stuck on my side. |
There was a problem hiding this comment.
🟢 Approval recommended
The referenced releases exist and retain compatibility with these hosted-runner workflows.
0 open findings
What changed in this PR
Updates CI workflows to supported major versions of core GitHub Actions.
Changes:
- Upgrades
actions/checkoutto v7.0.1. - Upgrades
actions/setup-pythonto v7.0.0. - Preserves existing Python matrices and inputs.
| File | Description |
|---|---|
.github/workflows/test.yml |
Updates actions for unit tests. |
.github/workflows/pylint.yml |
Updates actions for linting. |
.github/workflows/contrib.yml |
Updates actions for contrib tests. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
@katsugtgz thank for this! @jasonacox-sam Please help with this. |
jasonacox-sam
left a comment
jasonacox-sam
left a comment
There was a problem hiding this comment.
Reviewing this now — @jasonacox, on it.
Reviewed the full diff: three workflow files, actions/checkout v3 → v7.0.1 and actions/setup-python v4 → v7.0.0, no other changes. Both versions exist and are the current majors, and Copilot's pass came back with 0 findings.
Two small notes, neither blocking:
- The PR pins exact versions (
v7.0.1/v7.0.0) while the repo's existing style uses major tags (v3,v4). Exact pins are arguably safer for CI reproducibility — just a style difference to be aware of. - The
contrib.ymlandtest.ymlmatrices still include Python 3.7 onubuntu-22.04. Newersetup-pythonmajors have been deprecating/dropping EOL Python versions, so if the first run of the 3.7 leg fails after this lands, that'll be the reason — not the action bump itself.
The contributor also noted the runs show action_required because it's the first PR from their fork — a maintainer approval click on the workflow page is needed to let them start; nothing wrong on their side.
Approving — safe, minimal, well-scoped.
@jasonacox — this is ready for your merge decision.
— Sam ⚙️
|
Merged. Thanks @katsugtgz and @jasonacox-sam ! |
Updates the actions in test.yml, contrib.yml, and pylint.yml.
actionlint reports checkout@v3 as too old to run on GitHub Actions, so these jobs fail today. setup-python keeps the same python-version input; the only input removed in v7 (pip-install) is not used here, and the 3.7 to 3.12 matrix is unaffected.
Validation: actionlint passes on the three files.
Scope: CI workflow files only. codeql-analysis.yml is left out since it needs a separate github/codeql-action update.