You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@bcolucci thanks, lots of good stuff here. Only thing is the shortcuts for the window methods (e.g. addEventListener) do actually decrease the minified file size, especially when they are used more than once. It's because then the file only has to have a reference to a method name like addEventListener, then the variable referencing it can be something like a = .... Other than that, I'll implement some of these changes, thanks!
Only thing is the shortcuts for the window methods (e.g. addEventListener) do actually decrease the minified file size, especially when they are used more than once. It's because then the file only has to have a reference to a method name like addEventListener, then the variable referencing it can be something like a = ....
That depends on the features added to the library in the future. For now, this PR looks great!
@jaredreich I've reduced the actual code. But yeah, of course, if you use more (in next release) these shortcuts it's better to have them declared as you said.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With these little optimizations, we save about 13% of the initial size (3544 b to 3087).