Skip to content

fix: harden plan-builder happy-path audits#233

Merged
jamil2018 merged 1 commit into
appraise-0.5from
codex/homechores-plan-builder-audit-fixes
Jul 19, 2026
Merged

fix: harden plan-builder happy-path audits#233
jamil2018 merged 1 commit into
appraise-0.5from
codex/homechores-plan-builder-audit-fixes

Conversation

@jamil2018

@jamil2018 jamil2018 commented Jul 19, 2026

Copy link
Copy Markdown
Owner

Summary

  • prevent false persistence warnings from generic apr and locator token matches
  • make automation workspace migration idempotent while preserving structured runtime helpers
  • return the current validation hash after baseline reconciliation repairs
  • reduce planning-flow retries with compact event reads, documented action limits, and clearer validation guidance
  • sync the scaffold, MCP contract/docs, and Graphify outputs

End-to-end audit

The HomeChores happy-path lifecycle completed planning, review, validation preparation, baseline, implementation, and completion in 27m 42s wall-clock time.

  • terminal event: plan_completed at sequence 48
  • managed final validation: 1/1 scenario and 38/38 steps, full assurance
  • final TestRun: 4beb9b76-18df-44b4-ac7e-1e9ff3c9ee39
  • independent browser pass: all behavior passed with zero console errors or warnings

The audit exposed semantic false positives, workspace-import rewrite churn, and avoidable retry/payload overhead; this PR contains the corresponding fixes and optimizations. Temporary plan, review, and validation evidence generated by the audit is intentionally excluded from the change set.

Validation

  • npm run validate — 957 unit tests and 38 Playwright E2E tests passed
  • npm run build — passed
  • plan-builder certification — 4 tests passed
  • appraisejs MCP package tests — 131 tests passed
  • create-appraisejs tests — 65 tests passed
  • harness and generated coordinator reference checks — passed
  • Fallow new-only gate — passed
  • React Doctor — 100/100
  • generated-artifact policy and focused secret scan — passed

@jamil2018
jamil2018 marked this pull request as ready for review July 19, 2026 09:19
@jamil2018
jamil2018 merged commit 4c120e9 into appraise-0.5 Jul 19, 2026
9 checks passed
@jamil2018
jamil2018 deleted the codex/homechores-plan-builder-audit-fixes branch July 19, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant