Harden plan builder lifecycle and agent setup#228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR packages the complete current AppraiseJS worktree and the related prior-session changes into one integration change against
appraise-0.5.It:
Context and impact
The ForgotSomething end-to-end audit exercised the real Appraise-owned lifecycle through plan approval, validation review, expected-red baseline acceptance, implementation, managed validation, and final completion. It exposed several defects that only appeared when the workflow was carried through every gate.
The MCP setup changes also incorporate the earlier connection diagnosis: registration state, sidecar liveness, and task capability snapshots are separate concerns. Repo-local stdio registration avoids requiring a long-lived coordinator bearer token in the Codex environment and works even when the package binary is not globally installed.
The existing project-scope proxy change is included as requested. A redirect makes the project-selection handoff visible to the browser and preserves the intended return URL instead of internally rewriting an unscoped resource request.
Root causes addressed
/eventswhile clients acknowledged through/events/ackValidation
packages/appraisejs: 119 tests passedpackages/create-appraisejs: 65 tests passednpm run build: passednpm --prefix packages/create-appraisejs run build: passedgit diff --check: passedNotes
The production build retains seven known Turbopack broad dynamic-path warnings. Full lint also reports warnings from immutable generated runtime capsules plus two existing source/test warnings; there are no lint errors.