Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
soxto the PyInstaller collection inbackend/build_binary.py.The Qwen TTS code path imports the Python
soxpackage. Explicitly collecting the package helps ensure it is included in the packaged VoiceBox server.Change
--collect-all soxto the PyInstaller arguments used by the server build.Testing context
This change was prepared during an experiment with VoiceBox on Windows 10 and an AMD Radeon RX 9070 XT using a PyTorch ROCm build.
In the separate experimental build, the GPU was detected and speech generation completed successfully. The original VoiceBox installation was kept unchanged.
These results describe one local setup and do not establish general ROCm or AMD GPU support.
Scope
This change addresses packaging of the Python
soxdependency. It does not implement ROCm support by itself.AI assistance disclosure
ChatGPT assisted with technical investigation, code analysis, and preparation of this patch. The change and supporting test observations should be reviewed by the maintainers before merging.