merge develop - #7
Open
jamessiddeley-amd wants to merge 149 commits into
Open
Conversation
Bumping version now that `release/rocm-rel-7.0` has been created Signed-off-by: David Galiffi <David.Galiffi@amd.com>
* Update soc_base.py Fixes #835 Signed-off-by: fxmarty-amd <felmarty@amd.com> * address comments --------- Signed-off-by: fxmarty-amd <felmarty@amd.com>
Bumps [rocm-docs-core](https://github.com/ROCm/rocm-docs-core) from 1.21.1 to 1.22.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.21.1...v1.22.0) --- updated-dependencies: - dependency-name: rocm-docs-core dependency-version: 1.22.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: vedithal-amd <Vignesh.Edithal@amd.com>
* Backport CHANGELOG changes from 7.0 release * Backport CHANGELOG changes from #815
* Fix ordering of metrics description
* Fix L2 cache bandwidth metrics for MI350 * Address review comments
* Only check file content hash consistency * Do not check file modification timestamps since that can be updated by git commands
* Add Utilization to metric name for Bandwidth related metrics whose Unit
is Percent
* Update Unit of Bandwidth metrics to Gbps
* Update metric Formula to use total duration as denominator instead of normalization unit.
* Update metric Description
* Update metric Unit
* Update CHANGELOG
[rocm-systems] ROCm/rocm-systems#96 (commit 89c74ac)
* Backport changelog from ROCm 7.0 RC3 cherry-pick PR
* ROCm/rocm-systems#93
[rocm-systems] ROCm/rocm-systems#116 (commit 448e5df)
[rocm-systems] ROCm/rocm-systems#121 (commit 2444c20)
RHEL8 now being supported until EOS, rebuilding rhel8 bins for rocm7 (previously built for rocm7 rhel9). Remove roofline-rhel9-rocm7, replace with new roofline-rhel8-rocm7. Update check for roof bin. Update any doc mentions of rhel min support version back to rhel8. [rocm-systems] ROCm/rocm-systems#122 (commit d8d739f)
* Remove .git folder and git command check in cmake
* Update docker container to work in monorepo
* Update docker container to mount the top level folder in monorepo
[rocm-systems] ROCm/rocm-systems#181 (commit 97d9f35)
* Use own counter definition * Do not depend on rocprofiler-sdk counter definition * Add missing counter definitions for MI100, MI200, MI300, MI350 series * Counters added based on register specification * This prevents some missing metrics * Enable SQC_DCACHE_INFLIGHT_LEVEL counter and associated metrics * Enable TCP_TCP_LATENCY counter and associated counter for all GPUs except MI300 * Update TCC_EA_* counters for MI100 to TCC_EA0_* * Update MI100 metrics which depend on TCC_EA0_* counters * Enable accumulation counters for MI100 * Improve rocprof list avail usage to get a better idea of supported counters * Update CHANGELOG * Move accumulation counters to counter definition [rocm-systems] ROCm/rocm-systems#91 (commit d3f9ab2)
* added ruff docs * style: Run ruff and black before yapf pass * yapf -r -i (23 fixes) * fixed conf.py and ran ruff format . * fixed conf.py 2 * formatted argparser.py * formatted src/rocprof_compute_analyze * formatted src/rocprof_compute_profile * formatted soc_base.py * formatted rocprof_compute_tui * formatted gui_components * formatted src/utils * formatted tests/ * format extra files * cleanup * fix test_utils.py * fixed typos * Update pyproject.toml * Update README.md * Update test_utils.py [rocm-systems] ROCm/rocm-systems#36 (commit 58d2a01)
* Add check for SQC_DCACHE csv in test script * Fix the list of csv files when profiling in tests [rocm-systems] ROCm/rocm-systems#227 (commit 002b960)
Fix formatting of CMakeLists.txt for cmake-format check Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com> [rocm-systems] ROCm/rocm-systems#222 (commit 3258c69)
[rocm-systems] ROCm/rocm-systems#223 (commit 0929e6e)
[rocm-systems] ROCm/rocm-systems#315 (commit 9a4983f)
* Fix IL1 Latency metric * Add SQC_ICACHE_INFLIGHT_LEVEL counter and corresponding accumulation counter to counter definitions * Add missing coll_level * Fix descriptions and tests [rocm-systems] ROCm/rocm-systems#276 (commit 63f3185)
* Backport from #860 [rocm-systems] ROCm/rocm-systems#342 (commit 80b7e6b)
* updated formatting workflow and docs * restored requirements.txt [rocm-systems] ROCm/rocm-systems#348 (commit 2936a46)
* remove references to --kernel-names * ruff format * remove redundant comments * update docs and roofline image * added two output lines to docs [rocm-systems] ROCm/rocm-systems#1543 (commit 42cc721)
runners with CDash (#1481) * Add nightly coverage workflow * ruff formatting * temp workflow testing * restore workflow file * add workflow condition * update workflow file * update workflow file * fix typo in run-ci.py * edit run-ci.py * add python deps install * add python deps install * add python deps install * add python deps install * check if enable coverage is on when using workflow * remove github CI breakdown and fix enable coverage * set cache variables must be set before dashboard starts * Update run-ci.py * Update run-ci.py to fix ctest cache * Update rocprofiler-compute-code-coverage.yml to install tests * Update rocprofiler-compute-code-coverage.yml * Restore workflow file * Update run-ci.py * Simplify workflow build command * Update run-ci.py to build tests * edited run-ci script * edit ctest configure commands * edit ctest configure commands to be on one line * edit ctest configure command to include path to amdclang++ * update clang check in tests/cmakelists.txt * update rocm * update rocm * update rocm version 7.0.2 * update tests/CMakeLists.txt * use tarball instead for rocm install * apt install rocm-dev instead for 7.0.0 release * workflow tweaks * update to use new 'tools' dir * install rocm-dev * add CMAKE_CXX_COMPILER as clang * update tests/cmakelists.txt * update cdasg site and build names * remove run automatically on pull requests * ruff format * increased timeouts for tests * add back reruns for workflow testing * fix typo * rename workflow "nightly" -> "code" * added tracks to keep track of gpu (325 vs 355) * remove test_db_connector.py * revert build names and tracking * update workflow pushes * CMake format * changed parallel level back to 1 [rocm-systems] ROCm/rocm-systems#1481 (commit d49e2e3)
of ROCm 7.2 release (#1908) [rocm-systems] ROCm/rocm-systems#1908 (commit 44a32e2)
* roll back json file processing logic for pc sampling * format cmake files * Revert "format cmake files" This reverts commit e64df65a8f30abcb6738e3a0d7ffd4270bd1d302. [rocm-systems] ROCm/rocm-systems#1835 (commit 15e5f09)
* attach: rename librocprofv3-attach - Renames library to librocprofiler-sdk-rocattach - ROCAttach library will be formalized and documented in future commit * Address review comments - Rename rocprofv3-attach.py to rocprof-attach.py - Use common filesystem.hpp in rocattach * Fix component name typo * Doc fixup [rocm-systems] ROCm/rocm-systems#1342 (commit 1271813)
Force tencentos to use rhel-based bin since tencent is branched off of centos, which is branch of fedora. Verified rocprof-compute run correctly selects bin to use, and the roofline benchmark values look similar between runs on rhel vs tencentos4 docker images on same system. Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com> [rocm-systems] ROCm/rocm-systems#1830 (commit 8418895)
* Split roofline tests * Use N/A for missing values * Test eval_expression for no valid data * Fixed tests * Updated Changelog for N/A * Fixed platform specific test failure [rocm-systems] ROCm/rocm-systems#1913 (commit 76ea357)
[rocm-systems] ROCm/rocm-systems#1887 (commit c778acd)
[rocm-systems] ROCm/rocm-systems#1933 (commit 9efd330)
* draft testing fix for no copyright file and no changelog * test fix no-changelog no-copyright * changelog copyright fixt * remove utils.cmake * rocr lintian * lintian overrides, copyright, changelog install * fix lintian overrides install * comp_type static fix and remove debug logs * syntax error * update static build check * update file permissions to 0755 to fix error control-file-has-bad-permissions 0664 != 0755 * fix lintian errors in rdc and remove logs from roctracer * lintian error fix rocprofiler * fix lintian error * mmove lintian overrides install * lintian errors fix * move lintian overrides install * use changelog already provided by rdc * fix formatting use existing changelog if provided * fix formatting use changelog in rocprofiler * draft testing fix for no copyright file and no changelog * test fix no-changelog no-copyright * changelog copyright fixt * lintian overrides, copyright, changelog install * fix lintian overrides install * comp_type static fix and remove debug logs * fix lintian errors in rdc and remove logs from roctracer * lintian error fix rocprofiler * fix lintian error * mmove lintian overrides install * lintian errors fix * move lintian overrides install * use changelog already provided by rdc * fix formatting use existing changelog if provided * fix formatting use changelog in rocprofiler * remove overrides. Use existing changelog and copyright * resolve merge conflict * update license for hsa-rocr. Use NCSA license * install license * install license [rocm-systems] ROCm/rocm-systems#1578 (commit 6b8aae3)
[rocm-systems] ROCm/rocm-systems#1954 (commit 8334255)
* Run gersemi formatting on cmake files in compute * Run gersemi again but on updated version [rocm-systems] ROCm/rocm-systems#1997 (commit e68873c)
[rocm-systems] ROCm/rocm-systems#1691 (commit 792ecc1)
* ChangeLog * Deprecation notice in old arch * Deprecation notice current arch * New config hash * Added Config deltas * Added metric description [rocm-systems] ROCm/rocm-systems#1822 (commit fd61b0f)
killed if test of attach/detach fails (#2139) * add try catch to ensure subprocess killed if test of attach/detach fails * remove unnecessary comments * remove duplicated cleanup [rocm-systems] ROCm/rocm-systems#2139 (commit 092ca13)
Runners (#1455) * Initial work in progress for compute CI workflow * Update run-ci.py script location, enable test creation * Add new lines to files * Add coverage file argument to run-ci.py * Remove run-ci.py script usage from rocprofiler-compute-continuous-integration.yml workflow * Add --break-system-packages parameter * Add --ignore-installed to pip install * Checkout specific branch until amdclang issue fixed in develop * Add missing slash to path for cxx compiler * Remove specific branch from checkout action * Use run-ci.py in rocprofiler-compute-continuous-integration.yml * Update install python requirements step * Fix typo in build-name * Update run-ci.py to have toggle for code coverage * Apply ruff formatting * Ruff again * Exclude live attach detach and roofline tests in CI * Add ctest args * Revert run-ci.py changes * Try new run-ci-2.py * Update type of pytest-numprocs argument * Try casting arg to str * Fix typo in arg reference * upgrade pip before running python installs * Use jammy instead of noble for CI * Remove python nproc arg from run-ci-2.py * Switch to MI325 runners for CI * Fix spacing issue * Rename run-ci.py to run-code-coverage.py, add new run-ci.py * Update to ROCm version 7.1.0 to debug sdk issues * Testing out tarball install again * Update regex on tarball version * Update tarball regex on compute * ruff formatting * Revert change to systems CI file * Switch back to rocm-dev install * ruff formatting again * Add ld_lib_path for rocm_sysdeps * Remove excluded tests temporarily * Add back excluded tests, add timeout for test step * Address PR feedback * Add git safe directory lines * Revert dependencies change to debug new failures * Exclude roofline again, rework dependencies * Add in hip-runtime-amd dependency * Install hip dev package * Add TEST_FROM_INSTALL cmake arg to compute CI workflow * Remove test_from_install for now * Enable roofline tests again [rocm-systems] ROCm/rocm-systems#1455 (commit 3b875cc)
case (#2217) * fix roof test to be isolated file paths * fix typo * addressed comments * fix typos [rocm-systems] ROCm/rocm-systems#2217 (commit d27bd37)
(#2160) * modified changelog for docs updates 7.2 * update documentation for 7.2 * update FAQ wording * Update projects/rocprofiler-compute/docs/reference/faq.rst Co-authored-by: cfallows-amd <Carrie.Fallows@amd.com> * addressed comments * fixed header for 'On MI350 and newer platforms' * Update projects/rocprofiler-compute/src/rocprof_compute_soc/analysis_configs/gfx950/1100_compute_units_compute_pipeline.yaml Co-authored-by: cfallows-amd <Carrie.Fallows@amd.com> * ruff format [rocm-systems] ROCm/rocm-systems#2160 (commit 8f452d2)
files (#2279) * merged code-coverage and continuous workflow files * fixed runner typos and added build mode * add actor name to Continuous build * improve error handling and remove redundant verbose * fixed workflow file log output * revert logs output in run_ci.py * ruff format [rocm-systems] ROCm/rocm-systems#2279 (commit 8172018)
rocprofiler-compute-tarball.yml workflow (#2329) * Install rocm-dev in rocprofiler-compute-tarball.yml workflow * Update paths for push and PR for rocprofiler-compute-tarball.yml * Add ROCm dependencies to disttest job * cmake fix binary link creation and fix format * Use python3 instead of python3.9 in RHEL 8 and RHEL 9 workflows * set default python3 to python3.9 in rhel8 * Try alternatives setup for python3 in RHEL8 env * Add pip install cmake to debug RHEL8 issue * Remove python3.11 in RHEL8 workflow * Add back comment regarding RHEL8 [rocm-systems] ROCm/rocm-systems#2329 (commit 112b4fd)
(#2314) * Added tool for dumping counter and metric values * Skip Linting * Added support for iteration multiplexing * Remove subparser and supress compute options * Specify output dir * Add kernel info * csv name change * Added comments * Support dispatch id-less dataframes * Formatting fix * Add default for path * Print help with no args * Support only single workload [rocm-systems] ROCm/rocm-systems#2314 (commit 983386e)
[rocm-systems] ROCm/rocm-systems#2462 (commit ca32193)
(#2467) * Update rocprofiler workflows to use new runner naming for mi325 * Add input options to workflow_dispatch for rocprofiler-systems CI workflow * Update runner name on therock-ci-linux.yml as well [rocm-systems] ROCm/rocm-systems#2467 (commit 1d5a6e9)
config_hashes json had mismatched md5s for the delta_hash values, regenerated the file with the existing files in develop branch. Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com> [rocm-systems] ROCm/rocm-systems#2530 (commit ae1abe4)
MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Replace O(n^2²) nested loop with O(1) dictionary lookup when associating metric values with metrics. Pre-group values by (metric_id, kernel_name) to eliminate redundant iteration over entire values dataframe for each metric-kernel combination. * This optimization significantly improves database write performance for workloads with large numbers of metrics and kernels. [rocm-systems] ROCm/rocm-systems#2557 (commit d65de0a)
container (#2661) * Use TheRock nightly builds in testing container * Add HIP_DEVICE_LIB_PATH env var for hipcc to work * Add HIP_PLATFORM env var for cmake hip package * Add tarball placeholder * Add -f to curl command to fail on HTTP error [rocm-systems] ROCm/rocm-systems#2661 (commit a926660)
Continuous-Integration CI workflow (#2797) * fix silent failures in rocprof-compute continuous-integratin CI workflow * CDash uploads complete before the script fails [rocm-systems] ROCm/rocm-systems#2797 (commit dbd26a8)
* Initial cleanup of compute workflows and skeleton of ghcr workflow * Add containers-ci.yml, update opensuse and rhel dockerfiles * rename id in rocprofiler-compute-ghcr.yml * Add new line to end of containers-ci.yml * Update action versions for rocprofiler-compute-ghcr.yml * Switch back to SHA for action versions * Add conda set solver classic fix to compute CI dockerfiles * Update conda install for compute Dockerfiles * Change opensuse version to 15.6 in containers-ci.yml * Add fix for ubuntu noble to compute Dockerfile.ubuntu.ci * Add default distro and version to Dockerfile.ubuntu.ci * Updated regex for tarball version * Remove Python3.8 from compute CI Dockerfiles * Change RHEL 9.4 to 9, add retry for compute workflow * Revert name change for compute rhel workflow * update path naming * Remove binutils-gold from Dockerfile.opensuse.ci * Remove conda python installs from Dockerfile.ci files in compute * Change CMake version to 3.21 in compute Dockerfile.ci files * Update checkout actions from v4 to v5 [rocm-systems] ROCm/rocm-systems#1195 (commit 1255ba2)
SHA to 2026-02-02 (#3020) - Also update runner label from linux-mi325-1gpu-ossci-rocm-frac to linux-mi325-1gpu-ossci-rocm [rocm-systems] ROCm/rocm-systems#3020 (commit 98d6ca1)
* Fixed list blocks output * Updated test [rocm-systems] ROCm/rocm-systems#3232 (commit c6140f2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rocprofiler-compute Pull Request
Related Issue
What type of PR is this? (check all that apply)
Technical Details
Have you added or updated tests to validate functionality?
Added / Updated documentation?
Have you updated CHANGELOG?