Add ability to fetch the WSDL with NTLM Auth.#11
Open
das-peter wants to merge 2 commits into
Open
Conversation
|
Hey guys, any reason this PR is not yet merged? 🤔 |
vincentchalamon
approved these changes
Nov 26, 2019
vincentchalamon
left a comment
vincentchalamon
left a comment
There was a problem hiding this comment.
I can confirm this fixes SOAP calls with a NTLM auth.
I need this in a Symfony bundle, would be great to be merged! :-)
|
Would be nice if this gets merged if it is confirmed to be working |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #4 - WSDL fetching not working.
It's not a great solution but one that should work ;)
As for the mentioned https://github.com/matejsvajger/ntlm-soap-client - I'm a bit afraid that this approach could interfere with other http fetches because it overwrites the 'http' stream wrapper: https://github.com/matejsvajger/ntlm-soap-client/blob/master/src/NTLMSoap/Model/BaseClient.php#L31