Skip to content

Fixed doc typos re: @Jsonb(De)Serializer#183

Draft
mkarg wants to merge 1 commit into
jakartaee:masterfrom
mkarg:GH-70
Draft

Fixed doc typos re: @Jsonb(De)Serializer#183
mkarg wants to merge 1 commit into
jakartaee:masterfrom
mkarg:GH-70

Conversation

@mkarg

@mkarg mkarg commented Aug 21, 2019

Copy link
Copy Markdown
Contributor

Partial fix of #70 (JavaDocs only)

Unfortunately I could only fix the JavaDocs, as there is just boilerplate for the actual spec.

Closes jakartaee#70

Signed-off-by: Markus KARG <markus@headcrashing.eu>
@mkarg

mkarg commented Aug 21, 2019

Copy link
Copy Markdown
Contributor Author

I marked this PR as a draft, as the spec source is not contained. Please tell me if I shall keep it in draft state until the spec source is available, or whether I shall turn it in a real PR so you could merge it. Thanks. :-)

@aguibert

Copy link
Copy Markdown
Contributor

hi @mkarg thanks for the PR! I agree it would be good to update the spec doc at the same time as the javadoc so we don't lose track and the spec and javadoc become inconsistent with each other.

@m0mus do we have an ETA on when the real spec doc will be available on this repo?

@aguibert aguibert added the documentation Involves the spec or javadocs label Aug 27, 2019
@m0mus

m0mus commented Aug 27, 2019

Copy link
Copy Markdown
Contributor

@aguibert You better ask Eclipse folks. They need to do some legal checks before allowing us using the old spec text.

@mkarg

mkarg commented Aug 27, 2019

Copy link
Copy Markdown
Contributor Author

@m0mus Did EF already ask you for your approval of the spec? I was asked weeks ago and it seems nothing happend so far.

So how to proceed? Keep the PR in draft state until we have the OK from the EF, or merge this PR, keep the issue open, and create another PR for the spec change?

@m0mus

m0mus commented Aug 28, 2019

Copy link
Copy Markdown
Contributor

@mkarg No, I didn't have any request from EF regarding the spec. I suppose that it will happen after Jakarta EE 8 release.

@jungm

jungm commented Mar 4, 2025

Copy link
Copy Markdown
Contributor

Spec document has been merged a long time ago (3b879d7), can we get this PR merged or possibly even extended to also fix the spec?

customer.setName("Freddie");

// Also configurable with @JsonbSerializer / JsonbDeserializer on properties and class.
// Also configurable with @JsonbTypeSerializer / @JsonbTypeDeSerializer on properties and class.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Also configurable with @JsonbTypeSerializer / @JsonbTypeDeSerializer on properties and class.
// Also configurable with @JsonbTypeSerializer / @JsonbTypeDeserializer on properties and class.

@KyleAure

Copy link
Copy Markdown
Member

@mkarg - please resolve the merge conflicts and see my review above. I'd like to get this merged.

@KyleAure KyleAure self-assigned this May 26, 2026
@KyleAure KyleAure added this to the 3.1 milestone May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Involves the spec or javadocs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants