Add cellZone selectionMode support for MeanVelocityForce#246
Open
kevinsmia1939 wants to merge 1 commit intojaheyns:masterfrom
Open
Add cellZone selectionMode support for MeanVelocityForce#246kevinsmia1939 wants to merge 1 commit intojaheyns:masterfrom
kevinsmia1939 wants to merge 1 commit intojaheyns:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add selection mode cellZone support to mean velocity force and is the continuation of #244. Probably the last of what I want to add to this.
The main goal of this PR,
Add support for selecting solid to use as cell zone instead of all for previous PR.
Support multiple solid as cell zone.
I avoid changing existing function in CfdCaseWriterFoam.py so exportMeanVelocityForceCellZoneStlSurfaces was introduce even if very similar exportZoneStlSurfaces exist juust to avoid breaking anything.
Add test case for mean velocity force selection mode cell zone and update test case for mean velocity force selection mode all. The test case are just comparing case output to known good value.
Add readme and new screenshot.
Important to note that majority of the code are written with Claude AI. To make sure that this is not slop, I ran several test case as shown below.
Test 1, flow thought tube bundle with periodic boundary. The flow is driven by mean vel force cellzone (rectangle in the center).
ParaView output
Multiple solid assign as mean velocity force with cellzone. The flow are force in different directions.
ParaView result, this is also include in Demos folder.
All test pass except propeller, which is not related to this PR.