fix: align icon filename with cursor.desktop and drop deprecated xorg.*#60
Open
jacopone wants to merge 1 commit into
Open
fix: align icon filename with cursor.desktop and drop deprecated xorg.*#60jacopone wants to merge 1 commit into
jacopone wants to merge 1 commit into
Conversation
cursor.desktop ships Icon=co.anysphere.cursor, but the AppImage exports the icon as cursor.png — so desktop launchers couldn't resolve it. Rename on install to bridge the gap. Also replace xorg.libX11 et al. with their top-level equivalents (libx11, libxcomposite, libxdamage, libxext, libxfixes, libxrandr, libxcb) to silence the 12 deprecation warnings emitted by current nixpkgs. The redundant xorg.libxkbfile is dropped (libxkbfile was already listed). Both changes originate from #50, which was closed as superseded on the hash bump it was bundled with. Co-Authored-By: Max <maxmiller1204@outlook.com> Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cursor.pngtoco.anysphere.cursor.pngto match theIcon=co.anysphere.cursorfield shipped incursor.desktop— desktop launchers can now resolve the iconxorg.libX11and siblings with their top-level equivalents (libx11,libxcomposite,libxdamage,libxext,libxfixes,libxrandr,libxcb) — silences 12 deprecation warnings emitted by current nixpkgsxorg.libxkbfileline (libxkbfilewas already listed)Background
Both changes originate from #50 by @max-miller1204, which was closed after being superseded by direct hash refreshes on
main(3.0.13 → 3.0.16 → 3.1.x → 3.2.x → 3.3.30). Reapplied here against currentmainwith credit preserved as a co-author on the commit.Verification
nix flake check— passes with zero deprecation warnings (was 12)nix build .#cursor— succeeds against 3.3.30result/share/icons/hicolor/*/apps/co.anysphere.cursor.pngexists in build outputcursor.desktopin 3.3.30 still referencesIcon=co.anysphere.cursorTest plan
🤖 Generated with Claude Code